Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.freedesktop.Sdk.Extension.node20 #4895

Closed
wants to merge 4 commits into from

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Jan 28, 2024

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

First try to build this froze my laptop - but it's basically a copy job of the node18 package.

@bbhtt bbhtt changed the title Add node 20 sdk Add org.freedesktop.Sdk.Extension.node20 Jan 28, 2024
@bbhtt
Copy link
Contributor

bbhtt commented Jan 28, 2024

bot, build org.freedesktop.Sdk.Extension.node20

@flathubbot
Copy link

Queued test build for org.freedesktop.Sdk.Extension.node20.

@flathubbot
Copy link

Started test build 96215

@flathubbot
Copy link

Build 96215 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/78967/org.freedesktop.Sdk.Extension.node20.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented Jan 28, 2024

Can you also symlink node-gyp to $FLATPAK_DEST/bin? It's in lib/node_modules/npm/bin/node-gyp-bin/node-gyp

There are some leftover man pages too.

Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
@razzeee
Copy link
Member Author

razzeee commented Jan 28, 2024

There are some leftover man pages too.

How did you check that?

@hfiguiere
Copy link
Contributor

look at the content of the build dir. everything in files

@razzeee
Copy link
Member Author

razzeee commented Jan 28, 2024

Guess I will have to buy more RAM to figure this out then :D

@bbhtt
Copy link
Contributor

bbhtt commented Jan 29, 2024

You can also install the test build and check ~/.local/share/flatpak/runtime/<id>/23.08/files

@razzeee
Copy link
Member Author

razzeee commented Jan 30, 2024

bot, build org.freedesktop.Sdk.Extension.node20

@flathubbot
Copy link

Queued test build for org.freedesktop.Sdk.Extension.node20.

@flathubbot
Copy link

Started test build 96785

@flathubbot
Copy link

Build 96785 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79546/org.freedesktop.Sdk.Extension.node20.flatpakref

@razzeee
Copy link
Member Author

razzeee commented Jan 30, 2024

bot, build org.freedesktop.Sdk.Extension.node20

@flathubbot
Copy link

Queued test build for org.freedesktop.Sdk.Extension.node20.

@flathubbot
Copy link

Started test build 96847

@flathubbot
Copy link

Build 96847 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79608/org.freedesktop.Sdk.Extension.node20.flatpakref

@razzeee
Copy link
Member Author

razzeee commented Jan 31, 2024

Man pages and docs should be gone now too

@bbhtt bbhtt added the ready label Feb 3, 2024
@barthalion
Copy link
Member

/merge:23.08

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.freedesktop.Sdk.Extension.node20

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants