Add org.gnome.Brasero #4960
Add org.gnome.Brasero #4960
Conversation
- Remove freetype, it's provided by runtime - Add libcddb, wanted by libcdio - Add imagemagick, wanted by dvdauthor - Move libcdio to top so it can provide for libburn - Add config-opts to disable static builds, docs, and optimise builds - Add fallback-x11 to finish args
Adds x-checker-data to all modules except dvdauthor, for which I need to backport changes to a stable release, and cdrkit, for which I'm not sure of the situation with distrotech.
Fixes x-checker-data, corrects checksums, moves dvd+rw-tools to match Brasero's plugin list.
Add's notes to non-upstreamed patches, uses an already open MR for AppStream patch, and adds release history.
Use Brasero MR !25 (https://gitlab.gnome.org/GNOME/brasero/-/merge_requests/25) for Appstream, and remove a screenshot that is not wide enough for appstream-glib
|
bot, build |
|
Ignoring bot build request due to repo lookup error: Invalid id flathub. |
|
bot, build org.gnome.brasero |
|
Queued test build for org.gnome.brasero. |
|
Started test build 100880 |
|
Build 100880 failed |
|
bot, build org.gnome.Brasero |
|
Queued test build for org.gnome.Brasero. |
|
Started test build 100881 |
|
Build 100881 was cancelled |
|
Copy and replace config.guess, sub with the ones from runtime |
|
bot, build org.gnome.Brasero |
|
Queued test build for org.gnome.Brasero. |
|
Started test build 101083 |
|
Build 101083 successful |
|
Re. screenshots: if you give me your wiki.gnome.org username, I'll add you to https://wiki.gnome.org/TrustedEditorGroup so you can update the screenshots. Another approach used by a lot of apps is to check the screenshots into Git (either the flathub repo, or the upstream) and link to the blob. |
|
I suppose I can give a shot at taking some screenshots. My username is DanielFoster. Should I post the screenshots here before I overwrite the old ones? |
|
Added you there. https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#screenshots has some guidelines. Assuming that you're using GNOME, https://extensions.gnome.org/extension/881/screenshot-window-sizer/ may be useful to resize the window to the appropriate size & aspect ratio. |
|
Thanks! |
This was a whole ordeal which I'm tempted to rant about but won't.
|
I have updated the screenshots, however Brasero no longer shows the main window behind dialogues, which means the CD copy screenshot is really small, so I have replaced it with the screenshot of the new project screen, and submitted the change upstream. |
|
bot, build org.gnome.Brasero |
|
Queued test build for org.gnome.Brasero. |
|
Started test build 101245 |
|
Build 101245 successful |
|
cleanup |
|
/merge |
|
A repository for this submission has been created: https://github.com/flathub/org.gnome.Brasero You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Please confirm your submission meets all the criteria
Rationale for the non-upstreamed patches:
patch/brasero-vcdimager-version.patch, which updates the supported version of vcdimager, hasn't been submitted upstream as I haven't tested the vcdimager plugin, because I do not have any VCD hardware.patch/dvdauthor-no-doc.patchjust disables documentation, as I don't believe dvdauthor's buildsys allows you to do this. This obviously shouldn't be upstreamed.patch/use-app-dir.patchchanges the installation prefix. It isn't used though, as I have yet to get cdrtools to install successfully, and so it is disabled. Again, obviously shouldn't be merged upstream.