Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.riftr.intelpy #5111

Closed
wants to merge 11 commits into from
Closed

Add io.github.riftr.intelpy #5111

wants to merge 11 commits into from

Conversation

Riftr
Copy link

@Riftr Riftr commented Mar 31, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
    IntelPy is a cross-platform chat log monitor and alert system for the game Eve Online.

  • I have read the App Requirements and App Maintenance pages.

  • My pull request follows the instructions at App Submission.

  • I have built and tested the submission locally.

  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)

  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.

  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:

  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

io.github.riftr.intelpy.yml Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

The top of the PR template say the PR should be made against the new-pr branch. This is not the case.

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of the required .desktop, icon and appstream file installed.

@bbhtt bbhtt added the blocked label Mar 31, 2024
@Riftr
Copy link
Author

Riftr commented Apr 2, 2024

I don't see any of the required .desktop, icon and appstream file installed.

I've added these now. I had them ready in my own repo and I wasn't sure if I needed to specifically move them.

@bbhtt bbhtt removed the blocked label Apr 2, 2024
@bbhtt
Copy link
Contributor

bbhtt commented Apr 2, 2024

bot, build io.github.riftr.intelpy

@flathubbot
Copy link

Queued test build for io.github.riftr.intelpy.

@flathubbot
Copy link

Started test build 111770

@flathubbot
Copy link

Build 111770 failed

@bbhtt
Copy link
Contributor

bbhtt commented Apr 3, 2024

You have to change the screenshots to raw.githubusercontent.com links like this https://raw.githubusercontent.com/Riftr/intelpy/master/intelpy/externals/Intelpy-2-main.png

It has to be a direct link, a link to a page won't work.

@Riftr
Copy link
Author

Riftr commented Apr 4, 2024

You have to change the screenshots to raw.githubusercontent.com links like this https://raw.githubusercontent.com/Riftr/intelpy/master/intelpy/externals/Intelpy-2-main.png

It has to be a direct link, a link to a page won't work.

I've made and pushed the change for this now too.

@bbhtt
Copy link
Contributor

bbhtt commented Apr 4, 2024

You have to update the tag/commit here.

@Riftr
Copy link
Author

Riftr commented Apr 5, 2024

You have to update the tag/commit here.

New release has been added here.

@bbhtt
Copy link
Contributor

bbhtt commented Apr 5, 2024

bot, build io.github.riftr.intelpy

@flathubbot
Copy link

Queued test build for io.github.riftr.intelpy.

@flathubbot
Copy link

Started test build 112501

@flathubbot
Copy link

Build 112501 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95311/io.github.riftr.intelpy.flatpakref

@barthalion
Copy link
Member

bot, build io.github.riftr.intelpy

@flathubbot
Copy link

Queued test build for io.github.riftr.intelpy.

@flathubbot
Copy link

Started test build 112901

@flathubbot
Copy link

Build 112901 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95707/io.github.riftr.intelpy.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/io.github.riftr.intelpy

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Apr 7, 2024
@Riftr
Copy link
Author

Riftr commented Apr 8, 2024

Accepted, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants