Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.elevenhsoft.WebApps #5212

Closed
wants to merge 6 commits into from

Conversation

elevenhsoft
Copy link

@elevenhsoft elevenhsoft commented May 4, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

  • Cosmic Web Apps is simple app to manage web applications created from your web browser with isolated profile from given URL. It works with most of mainstream flatpak web browsers.

  • I have read the App Requirements and App Maintenance pages.

  • My pull request follows the instructions at App Submission.

  • I have built and tested the submission locally.

  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)

  • Unfortunately I was trying to reduce permissions to minimum but I need some rw access to ~/.var/app to write browser profile there like firefox for example which will allow you to isolate it from your main profile. Also rw access to xdg-data/application for creating desktop files user-wide.

  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.

  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://github.com/elevenhsoft/cosmic-wam

  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

org.cosmic.Wam.json Outdated Show resolved Hide resolved
org.cosmic.Wam.json Outdated Show resolved Hide resolved
@bbhtt bbhtt added awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels May 4, 2024
@elevenhsoft elevenhsoft changed the title Add org.cosmic.Wam Add io.github.elevenhsoft.WebApps May 4, 2024
@bbhtt bbhtt removed the blocked Pull requests that are blocked on something or won't be accepted in the currrent state label May 5, 2024
@bbhtt
Copy link
Contributor

bbhtt commented May 5, 2024

bot, build io.github.elevenhsoft.WebApps

@flathubbot
Copy link

Queued test build for io.github.elevenhsoft.WebApps.

@flathubbot
Copy link

Started test build 118948

@flathubbot
Copy link

Build 118948 failed

@bbhtt
Copy link
Contributor

bbhtt commented May 5, 2024

These should be a direct link to the image https://github.com/elevenhsoft/WebApps/blob/7b4b0c5dcbe670c4da1d4cb71a5f913b5f93bd2d/data/io.github.elevenhsoft.WebApps.metainfo.xml#L34-L43

Also make them from a tag instead of master like https://raw.githubusercontent.com/elevenhsoft/WebApps/0.3.4/res/screenshots/window-icon-picker.png

@elevenhsoft
Copy link
Author

These should be a direct link to the image https://github.com/elevenhsoft/WebApps/blob/7b4b0c5dcbe670c4da1d4cb71a5f913b5f93bd2d/data/io.github.elevenhsoft.WebApps.metainfo.xml#L34-L43

Also make them from a tag instead of master like https://raw.githubusercontent.com/elevenhsoft/WebApps/0.3.4/res/screenshots/window-icon-picker.png

Oh I see. Sorry for that. I will make a correction.

@elevenhsoft
Copy link
Author

I made some changes locally for now and tested repo linter but got this:

"appstream-screenshots-not-mirrored-in-ostree"

I'm not sure how to deal with it tbh.

@bbhtt
Copy link
Contributor

bbhtt commented May 5, 2024

You can ignore that.

@elevenhsoft
Copy link
Author

Awesome. So now I assume new tag, and updating the manifest.

@elevenhsoft
Copy link
Author

Done

@bbhtt
Copy link
Contributor

bbhtt commented May 6, 2024

bot, build io.github.elevenhsoft.WebApps

@flathubbot
Copy link

Queued test build for io.github.elevenhsoft.WebApps.

@flathubbot
Copy link

Started test build 119113

@flathubbot
Copy link

Build 119113 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/101954/io.github.elevenhsoft.WebApps.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented May 6, 2024

I don't think it is working? The install some browser drop down is showing nothing.

If I press create after entering title and URL it says ERROR webapps::wam: Error reading web app: Cannot read web app launcher.

@elevenhsoft
Copy link
Author

Yes it's working but you probably don't have any flatpak browsers installed. It works only with flatpak.
About this error. It's lack a check probably because I should not allow create launcher if browser is not choosen. So launcher is malformed.

Yes. It's definitely require this check.

Please install some flatpak browser first and check again. It's working just fine.

@bbhtt
Copy link
Contributor

bbhtt commented May 6, 2024

Ok yea the VM didn't have a Flatpaked browser. It works with Firefox from Flathub.

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 6, 2024
@elevenhsoft
Copy link
Author

Nice. Glad to hear it works for you. I'm gonna make a new release soon with some fixes but I hope it will be pushed further ^^

@barthalion
Copy link
Member

bot, build io.github.elevenhsoft.WebApps

@flathubbot
Copy link

Queued test build for io.github.elevenhsoft.WebApps.

@flathubbot
Copy link

Started test build 119748

@flathubbot
Copy link

Build 119748 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102600/io.github.elevenhsoft.WebApps.flatpakref

@barthalion
Copy link
Member

I recommend bundling Papirus icon theme instead of downloading it over network. This way your app won't need the network sandbox hole.

@barthalion
Copy link
Member

The search dialog for icon doesn't seem to work, I get a panic. And now, when I re-launched it, it downloads icons again.

@barthalion
Copy link
Member

Looks like there's no feedback that an icon is required – clicking the create button doesn't do anything, and neither of the icons buttons seem to work.

Not sure if this is specific to my environment (Fedora 39 Silverblue), but it doesn't seem to work correctly for me.

@elevenhsoft
Copy link
Author

I recommend bundling Papirus icon theme instead of downloading it over network. This way your app won't need the network sandbox hole.

The network permission is for downloading icon via Favicon. Some icons are not in papirus icons, and they are downloaded via internet. I know I need to improve downloading favicon a bit but for now it works.

@elevenhsoft
Copy link
Author

The search dialog for icon doesn't seem to work, I get a panic. And now, when I re-launched it, it downloads icons again.

Maybe something broken while installing icon theme. Kind of weird. I did a lot of changes recently, will I be able to update this PR with newer tags?

@elevenhsoft
Copy link
Author

Looks like there's no feedback that an icon is required – clicking the create button doesn't do anything, and neither of the icons buttons seem to work.

Not sure if this is specific to my environment (Fedora 39 Silverblue), but it doesn't seem to work correctly for me.

Yes bugs may appear. I could not be able to catch them all alone. I tested this on many distros as well configurations and worked. However I made a lot of changes and bug fixes lately, please look at master branch: https://github.com/elevenhsoft/WebApps

Unfortunately still struggling with one bug so I can't push it here yet but when I sort it out I will update PR.

In summary. What's need to be changed to go public? To be honest I hope to get more interested from outside with different configurations to fix them all. I can't catch all the possible bugs, even if I tried.

@barthalion
Copy link
Member

I did a lot of changes recently, will I be able to update this PR with newer tags?

Swap https://github.com/flathub/flathub/pull/5212/files#diff-29744291e26d21ae2b07178dd67be5e930c96f2ce6755768980e9dfab84be277R45-R46 for standalone commit pointing to the commit you would like us to test and ship.

In summary. What's need to be changed to go public?

At the very least I would like it to be functional on my system to make sure I know what we're distributing.

@elevenhsoft
Copy link
Author

Ok, I got it. Thank you for your tests. I will fix dropdown bug in my app (i don't know if it's libcosmic thing or my app, i'm investigating it) and I will be back. Sorry for confusions.

@elevenhsoft
Copy link
Author

Not sure if this is specific to my environment (Fedora 39 Silverblue), but it doesn't seem to work correctly for me.

Hey, I'm gonna install silverblue and test there. After many changes it should work correctly but I'm gonna see what's the case. If everything will be correct on my side I will update manifest with new version.

@elevenhsoft
Copy link
Author

@barthalion Hi again! :)

I just tested silverblue. Yeah. There was an issue with home directory. I was looking for /home/USER location and here it's in /var/home/USER

So now I'm using $HOME env in this case to recognize proper location. It works. I did also pushed my latest changes with many improvements.

Please check again. Make sure you have browser installed via flatpak.

@barthalion
Copy link
Member

bot, build io.github.elevenhsoft.WebApps

@flathubbot
Copy link

Queued test build for io.github.elevenhsoft.WebApps.

@flathubbot
Copy link

Started test build 119982

@flathubbot
Copy link

Build 119982 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102843/io.github.elevenhsoft.WebApps.flatpakref

@barthalion
Copy link
Member

bot, build io.github.elevenhsoft.WebApps

@flathubbot
Copy link

Queued test build for io.github.elevenhsoft.WebApps.

@flathubbot
Copy link

Started test build 120447

@flathubbot
Copy link

Build 120447 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/103307/io.github.elevenhsoft.WebApps.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/io.github.elevenhsoft.WebApps

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants