Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.maxizamorano.photopea-no-ads #5339

Open
wants to merge 2 commits into
base: new-pr
Choose a base branch
from

Conversation

MaxiZamorano
Copy link

@MaxiZamorano MaxiZamorano commented Jun 16, 2024

Name: Photopea no Ads

Description: In addition to removing the ads from Photopea, it also removes the box that the ads occupy so that the work area is not reduced.

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

- install -Dm644 /app/main/resources/icons/photopea.png /app/share/icons/hicolor/512x512/apps/com.maxizamorano.photopea-no-ads.png
sources:
- type: file
url: https://github.com/MaxiZamorano/photopea-no-ads/releases/download/v1.0.0/photopea_no_ads_build.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does that work on aarch64?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be built from source.

Copy link
Author

@MaxiZamorano MaxiZamorano Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does that work on aarch64?

I haven't tested it on aarch64, only x86_64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but an aarch64 package is still built with these x86_64 binaries. Why not building from source?

Comment on lines 12 to 13
- --socket=x11
- --socket=wayland
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either wayland with fallback-x11 or x11 alone. not both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either wayland with fallback-x11 or x11 alone. not both.

Done, I modified it.

@bbhtt
Copy link
Contributor

bbhtt commented Jun 17, 2024

The icon being used here is an exact copy of the original icon used by Photopea https://github.com/MaxiZamorano/photopea-no-ads/blob/main/icons/photopea.png

You cannot do that. You cannot also use someone else's brand name for your application, as such it cannot be named "Photopea no ads" https://github.com/MaxiZamorano/photopea-no-ads/blob/981e06566e6ba3f434655812b521230b1bc3874d/data/com.maxizamorano.photopea-no-ads.metainfo.xml#L5

See https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#no-trademark-violations

I'm also a bit concerned whether this is acceptable for Flathub or not (but we'll have a discussion about that later)

@bbhtt bbhtt added the blocked Pull requests that are blocked on something or won't be accepted in the currrent state label Jun 17, 2024
@MaxiZamorano
Copy link
Author

The icon being used here is an exact copy of the original icon used by Photopea https://github.com/MaxiZamorano/photopea-no-ads/blob/main/icons/photopea.png

You cannot do that. You cannot also use someone else's brand name for your application, as such it cannot be named "Photopea no ads" https://github.com/MaxiZamorano/photopea-no-ads/blob/981e06566e6ba3f434655812b521230b1bc3874d/data/com.maxizamorano.photopea-no-ads.metainfo.xml#L5

See https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#no-trademark-violations

I'm also a bit concerned whether this is acceptable for Flathub or not (but we'll have a discussion about that later)

There is currently a Photopea app on Flathub but it doesn't block ads, it also uses a Photopea icon and the Photopea name, what's the difference? I also see other apps on Flathub with brand names and icons.

@bbhtt
Copy link
Contributor

bbhtt commented Jun 17, 2024

Two wrongs don't make a right. We reserve the right to remove them from the store at any point.
The issue is being tracked #5228.

@MaxiZamorano
Copy link
Author

Two wrongs don't make a right. We reserve the right to remove them from the store at any point. The issue is being tracked #5228.

I understand, so I should modify icon, name and description? ID too?

@bbhtt
Copy link
Contributor

bbhtt commented Jun 17, 2024

Name and icon, yes. The description should describe your app, not Photopea.

@barthalion
Copy link
Member

This is also blocked for other reason: there's no way we're going to publish a web view blocking ads on a otherwise free website.

@bbhtt bbhtt mentioned this pull request Jun 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants