-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.maxizamorano.photopea-no-ads #5339
base: new-pr
Are you sure you want to change the base?
Add com.maxizamorano.photopea-no-ads #5339
Conversation
- install -Dm644 /app/main/resources/icons/photopea.png /app/share/icons/hicolor/512x512/apps/com.maxizamorano.photopea-no-ads.png | ||
sources: | ||
- type: file | ||
url: https://github.com/MaxiZamorano/photopea-no-ads/releases/download/v1.0.0/photopea_no_ads_build.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does that work on aarch64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be built from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does that work on aarch64?
I haven't tested it on aarch64, only x86_64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but an aarch64 package is still built with these x86_64 binaries. Why not building from source?
- --socket=x11 | ||
- --socket=wayland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's either wayland with fallback-x11 or x11 alone. not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's either wayland with fallback-x11 or x11 alone. not both.
Done, I modified it.
The icon being used here is an exact copy of the original icon used by Photopea https://github.com/MaxiZamorano/photopea-no-ads/blob/main/icons/photopea.png You cannot do that. You cannot also use someone else's brand name for your application, as such it cannot be named "Photopea no ads" https://github.com/MaxiZamorano/photopea-no-ads/blob/981e06566e6ba3f434655812b521230b1bc3874d/data/com.maxizamorano.photopea-no-ads.metainfo.xml#L5 I'm also a bit concerned whether this is acceptable for Flathub or not (but we'll have a discussion about that later) |
There is currently a Photopea app on Flathub but it doesn't block ads, it also uses a Photopea icon and the Photopea name, what's the difference? I also see other apps on Flathub with brand names and icons. |
Two wrongs don't make a right. We reserve the right to remove them from the store at any point. |
I understand, so I should modify icon, name and description? ID too? |
Name and icon, yes. The description should describe your app, not Photopea. |
This is also blocked for other reason: there's no way we're going to publish a web view blocking ads on a otherwise free website. |
Name: Photopea no Ads
Description: In addition to removing the ads from Photopea, it also removes the box that the ads occupy so that the work area is not reduced.
Please confirm your submission meets all the criteria