Add com.basiomeuspuga.Lector.json #891
Conversation
| "rename-desktop-file":"lector.desktop", | ||
| "rename-appdata-file":"lector.appdata.xml", | ||
| "finish-args":[ | ||
| "--filesystem=host", |
There was a problem hiding this comment.
what do you need host permissions for? That seems uncomfortably broad.
There was a problem hiding this comment.
I imagine books can be located anywhere in the filesystem. I myself keep my books stored in an NTFS filesystem shared between Windows and Linux that's mounted outside my home directory. That said, is it better to go with "--filesystem=host:ro"?
There was a problem hiding this comment.
It would be better to use xdg-desktop-portal but I'm not actually sure what it takes for Qt. @aleixpol any pointers?
There was a problem hiding this comment.
That I know of, it's not possible to open directories using portals.
|
bot, build com.basiomeuspuga.Lector |
|
Queued test build for com.basiomeuspuga.Lector. |
|
Started test build 799 |
| @@ -0,0 +1,143 @@ | |||
| { | |||
| "app-id":"com.basiomeuspuga.Lector", | |||
There was a problem hiding this comment.
this domain name doesn't exist? com.github.BasioMeusPuga.Lector might be better (or io.github.BasioMeusPuga.Lector if you have a website there) a bit more on app-id selection http://docs.flatpak.org/en/latest/conventions.html#application-ids
There was a problem hiding this comment.
Understood. This is my first time building one of these. Thank you for being patient.
|
Build 799 failed |
|
So the appdata doesn't pass the https://github.com/flathub/flathub/wiki/AppData-Guidelines listed above on x86-64, and you're trying to load x86-64 only python wheels on the other architectures which is why they fail. |
|
I guess I'm going to go into the documentation a little. I'll get back when I can figure out how to get some of these packages to compile from source in the manifest. |
|
if it's impossible you can filter architectures but we only do that was a last resort |
|
This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins |
Lector is a Qt based ebook reader with support for epub, pdf, fb2, mobi, azw / azw3 / azw4, cbr / cbz
See https://github.com/BasioMeusPuga/Lector