Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network access #38

Closed
wants to merge 1 commit into from
Closed

add network access #38

wants to merge 1 commit into from

Conversation

mifi
Copy link
Collaborator

@mifi mifi commented Dec 18, 2022

someone reported in mifi/lossless-cut#1055 that it doesn't work

this also makes version update notifications work

someone reported in mifi/lossless-cut#1055 that it doesn't work

this also makes version update notifications work
@flathubbot
Copy link
Contributor

Started test build 12293

@flathubbot
Copy link
Contributor

Build 12293 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/124723/no.mifi.losslesscut.flatpakref

@muelli
Copy link
Collaborator

muelli commented Dec 18, 2022

I'm confused. What's the network access for? I find it surprising that a video editor needs to access the Internet. Unless it's for a very good reason, I'd advise to shield the application from the Internet. And from the issue you linked, I cannot make out what the actual problem is. A version update notification doesn't make sense in Flatpak world, since the app cannot update itself.

@mifi
Copy link
Collaborator Author

mifi commented Dec 19, 2022

Oh yes you’re right, update notifications doesn’t make sense then. The other use case (linked issue) is for showing the Ukraine support link on the DROP FILE screen. If you don’t agree with showing that, then I think you can close this PR because you’re the maintainer of this flatpak. Can revisit later if the need for internet connection comes up in the future.

@muelli muelli closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants