Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested configs via env #49

Merged
merged 5 commits into from
Jun 21, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,22 @@ Responsible for loading the values parsed from `process.env` into the configurat
// Can optionally also be an Array of values to limit process.env to.
//
nconf.env(['only', 'load', 'these', 'values', 'from', 'process.env']);

//
// Can also specify a separator for nested keys (instead of the default ':')
//
nconf.env('__');
// Get the value of the env variable 'database__host'
var dbHost = nconf.get('database:host');

//
// Or use both options
//
nconf.env({
separator: '__',
whitelist: ['database__host', 'only', 'load', 'these', 'values']
});
var dbHost = nconf.get('database:host');
```

### Literal
Expand Down
23 changes: 18 additions & 5 deletions lib/nconf/stores/env.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

var util = require('util'),
common = require('../common'),
Memory = require('./memory').Memory;

//
Expand All @@ -17,9 +18,17 @@ var util = require('util'),
var Env = exports.Env = function (options) {
Memory.call(this, options);

this.type = 'env';
this.readOnly = true;
this.options = options || [];
options = options || {};
this.type = 'env';
this.readOnly = true;
this.whitelist = options.whitelist || [];
this.separator = options.separator || '';
if (options instanceof Array) {
this.whitelist = options;
}
if (typeof(options) === 'string') {
this.separator = options;
}
};

// Inherit from the Memory store
Expand All @@ -43,9 +52,13 @@ Env.prototype.loadEnv = function () {

this.readOnly = false;
Object.keys(process.env).filter(function (key) {
return !self.options.length || self.options.indexOf(key) !== -1;
return !self.whitelist.length || self.whitelist.indexOf(key) !== -1;
}).forEach(function (key) {
self.set(key, process.env[key]);
if (self.separator) {
self.set(common.key.apply(common, key.split(self.separator)), process.env[key]);
} else {
self.set(key, process.env[key]);
}
});

this.readOnly = true;
Expand Down
4 changes: 2 additions & 2 deletions lib/nconf/stores/memory.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ Memory.prototype.merge = function (key, value) {
}

return Object.keys(value).every(function (nested) {
return self.merge(fullKey + ':' + nested, value[nested]);
return self.merge(common.key(fullKey, nested), value[nested]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was just so that the only place where the : character is referenced is in common - plus, it seems like the right thing to do

});
};

Expand All @@ -207,4 +207,4 @@ Memory.prototype.reset = function () {
//
Memory.prototype.loadSync = function () {
return this.store || {};
};
};
11 changes: 11 additions & 0 deletions test/fixtures/scripts/nconf-nested-env.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/*
* nconf-nested-env.js: Test fixture for env with nested keys.
*
* (C) 2012, Nodejitsu Inc.
* (C) 2012, Michael Hart
*
*/

var nconf = require('../../../lib/nconf').env('_');

process.stdout.write(nconf.get('SOME:THING'));
4 changes: 4 additions & 0 deletions test/provider-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ vows.describe('nconf/provider').addBatch({
script: path.join(fixturesDir, 'scripts', 'nconf-hierarchical-file-argv.js'),
argv: ['--something', 'foobar'],
env: { SOMETHING: true }
}),
"when 'env' is set to true with a nested separator": helpers.assertSystemConf({
script: path.join(fixturesDir, 'scripts', 'nconf-nested-env.js'),
env: { SOME_THING: 'foobar' }
})
}
}
Expand Down
7 changes: 4 additions & 3 deletions test/stores/env-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ vows.describe('nconf/stores/env').addBatch({
"should have the correct methods defined": function (env) {
assert.isFunction(env.loadSync);
assert.isFunction(env.loadEnv);
assert.isArray(env.options);
assert.lengthOf(env.options, 0);
assert.isArray(env.whitelist);
assert.lengthOf(env.whitelist, 0);
assert.equal(env.separator, '');
}
}
}).export(module);
}).export(module);