Added an option to only show message and prevent “error: Invalid input for […]” from being shown #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2015 06:13
to prevent “error: Invalid input for […]” from being shown (only if a message is available)
|
👍 |
|
Can you add a new test case so we know it's working? Also can you not check in any changes that are purely formatting like: https://github.com/flatiron/prompt/pull/124/files#diff-3c1054acedccbe011b701520814527a9R56 and https://github.com/flatiron/prompt/pull/124/files#diff-3c1054acedccbe011b701520814527a9R639 ? That way the discussion can just be about the functionality of the new feature and not stylistic preferences. |
|
This functionality was added in #118 , you'll now get "Invalid Input..." OR your message, not both. The only thing this PR did differently was also give you the option to show neither. If you really need the option to show neither message you can submit a new PR, but IMHO that'd be a bad design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(only if a message is set)