Add optional app ID to builds #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You must have the necessary prefix to create a build with an app ID. It doesn't do anything yet, but in the future it will be used to control access to other APIs.
For builds that have an app ID set, check that the presented build token has that app prefix. This covers the build management endpoints, but not yet build repo downloads or the status page.
Allow build repos to be set as public or private. If no app ID is set, the default is public as before, but if an app ID *is* set, the default is private (but in either case can be overridden). flat-manager-client gains `--public_download`/`--no_public_download` flags to control this behavior. A private build requires a build token in order to download from it. A new scope is added, "download", which allows listing and downloading builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional app ID field to builds. Builds with an app ID require that app ID to be present in the token's
prefixesfield, protecting them from other users.This change doesn't affect existing build tokens or processes, but once it is merged, build processes should be updated to create their builds with an app ID.
Also adds private builds, which also require a token to download from the build repo.