Fix missing [ExtensionOf] metadata for sources #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bundled sources is not an extension though. Like, it has not extension point in the app, and the app does not need, nor use the bundled sources. |
Makes sense. But what behavior do we want when an app is masked and its Sources ref is installed, refrain from updating the Sources? If so we need some extra logic in |
The flatpak-metadata man page says the [ExtensionOf] section is optional, but looking at the Flatpak source it is used for functionality, so we shouldn't be leaving it out of Sources extensions.
mwleeds
force-pushed
the
fix-missing-extensionof-for-sources
branch
from
0069d8b
to
d1e54ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.