Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should should modify flatpak manifest to pull the HEAD commit #86

Closed
andyholmes opened this issue Jul 17, 2022 · 2 comments · Fixed by #89
Closed

Tests should should modify flatpak manifest to pull the HEAD commit #86

andyholmes opened this issue Jul 17, 2022 · 2 comments · Fixed by #89

Comments

@andyholmes
Copy link
Contributor

I noticed while working on #83 that (in the case of git, for example) flatpak-builder will build from the sources defined in the flatpak manifest. This isn't surprising, but it's almost certainly not what you want if your manifest points to your main branch and you are running tests on pull request.

I plan on taking a crack at this eventually, but if someone else wants to take it on before I do, feel free.
@andyholmes andyholmes changed the title Tests should should modify to manifest to pull the HEAD commit Tests should should modify flatpak manifest to pull the HEAD commit Jul 17, 2022
@bilelmoussaoui
Copy link
Member

We already do that no? What is the flatpak manifest you are using? because we expect people to use a type: dir in their manifest instead of a type: git

@andyholmes
Copy link
Contributor Author

Ah, I see! I've been using basically a copy of a manifest I use to build nightly bundles, with some minor changes such as -Dtests=true.

Would you accept a PR to add some documentation for this, to close this issue? From looking at some manifests, I'm guessing that that path: ... in the type: dir sources is relative to the manifest's location to the project root? For example:

/build-aux/flatpak/app.foo.Bar.json     => "path": "../../"
/deeper/path/structure/app.foo.Bar.json => "path": "../../../"

Is that right?

andyholmes added a commit to andyholmes/flatpak-github-actions that referenced this issue Jul 25, 2022
@andyholmes
docs: add a section with more explicit details about running tests
dc937cb 
Running tests with the `flatpak-builder` action is fairly simple, but
has some gotchas if you're not familiar with the process.

Add a section with some more explicit examples, detailing what the
developer needs to do to ensure the expected results.

closes flatpak#86
@andyholmes andyholmes mentioned this issue Jul 25, 2022
Merged
andyholmes added a commit to andyholmes/flatpak-github-actions that referenced this issue Jul 25, 2022
@andyholmes
docs: add a section with more explicit details about running tests
cf98ee5 
Running tests with the `flatpak-builder` action is fairly simple, but
has some gotchas if you're not familiar with the process.

Add a section with some more explicit examples, detailing what the
developer needs to do to ensure the expected results.

closes flatpak#86
bilelmoussaoui pushed a commit that referenced this issue Jul 28, 2022
@andyholmes @bilelmoussaoui
docs: add a section with more explicit details about running tests
1f558fd 
Running tests with the `flatpak-builder` action is fairly simple, but
has some gotchas if you're not familiar with the process.

Add a section with some more explicit examples, detailing what the
developer needs to do to ensure the expected results.

closes #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add a section with more explicit details about running tests andyholmes/flatpak-github-actions
2 participants
@andyholmes @bilelmoussaoui