search: Don't strip .desktop suffix overzealously

[mwleeds]

This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes #4535

[smcv]

I wonder whether repositories like Flathub should be automatically injecting

<bundle type="flatpak">org.telegram.desktop</bundle>

or

<bundle type="flatpak">app/org.telegram.desktop//stable</bundle>

into the collection metadata, so that we have an unambiguous way to map from entries in the collection metadata to Flatpak refs?

[smcv]

Huh, looks like they already do. Perhaps Flatpak should be reading those, instead of the <id>, since they're a lot less ambiguous?

[mwleeds]

Huh, looks like they already do. Perhaps Flatpak should be reading those, instead of the <id>, since they're a lot less ambiguous?

Yeah that would be more robust, and it looks we already use it elsewhere. But I guess we'd still have to check the <id> as a fallback, since that is required by the appstream spec and <bundle> is not.

[mwleeds]

I'll change this to use <bundle>. I also notice that #4426 will probably make this obsolete but still worth getting this in since there's no guarantee the libappstream port will be in before the next release.

[mwleeds]

Still seems to work as expected with the <bundle> changes

[mwleeds]

I added a patch to the #4426 branch which ensures we don't run into this issue there. Since the code here is only relevant for appstream-glib we can close this PR if #4426 is merged.