Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: flatpak search lists results with some invalid app ids ("Names must contain at least 2 periods") #4535

Closed
2 tasks done
cobratbq opened this issue Nov 2, 2021 · 1 comment · Fixed by #4536
Closed
2 tasks done

[Bug]: flatpak search lists results with some invalid app ids ("Names must contain at least 2 periods") #4535

cobratbq opened this issue Nov 2, 2021 · 1 comment · Fixed by #4536
Labels
bug

Comments

@cobratbq
Copy link

cobratbq commented Nov 2, 2021

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Flatpak version

1.12.2

What Linux distribution are you using?

Debian

Linux distribution version

bullseye

What architecture are you using?

x86_64

How to reproduce

When searching for flatpak applications using the commandline, some applications are listed with invalid app id. So far, all occurrences I have encountered are listed with app id consisting of 2 parts (1 separating period) which is illegal. In all occurrences I found, the actual app id is different, valid. So the listing shows incorrect information.

  1. flatpak search telegram
    Name                         Description                                            Application ID                         Version          Branch          Remotes
    Telegram Desktop             Telegram Desktop messenger                             org.telegram                           3.1.9            stable          flathub
    Kotatogram Desktop           Kotatogram Desktop messenger                           io.github.kotatogram                   1.4.1            stable          flathub
    LibreTrack                   Private, cross-platform package tracking app           ru.proninyaroslav.libretrack           1.3.0            stable          flathub
    Franz                        Messenger for the desktop                              com.meetfranz.Franz                    5.7.0            stable          flathub
    Delta Chat                   Delta Chat email-based messenger                       chat.delta                             v1.22.2          stable          flathub
  • It lists org.telegram but in actuality the app id is org.telegram.desktop.
    command: flatpak remote-info flathub org.telegram
    error: Invalid id org.telegram: Names must contain at least 2 periods
    command: flatpak remote-info flathub org.telegram.desktop 
    ID: org.telegram.desktop
Ref: app/org.telegram.desktop/x86_64/stable
Arch: x86_64
Branch: stable
Collection: org.flathub.Stable
Download: 83.0 MB
Installed: 218.0 MB
Runtime: org.freedesktop.Platform/x86_64/21.08
Sdk: org.freedesktop.Sdk/x86_64/21.08

Commit: 78991b6beea36e4922f0992690920b74df2e800c1f42afeb0811c64f115f3bb7
Parent: 5e29c92bb322315dfd478a67bf1e1063ee9c9722a4b8613eea858c6b6e779614
Subject: Update tdesktop.git to 3.1.9 (22d03ba7)
Date: 2021-10-12 19:45:56 +0000
  • It lists chat.delta but in actuality the app id is chat.delta.desktop.

Expected Behavior

Search results of flatpak search should list actual app id, and preferably without arbitrary truncation in case of long app id. (truncated with ...)

Actual Behavior

Include in reproduction recipe. Lists wrong app id. Should be correct app id.

Additional Information

No response
@cobratbq cobratbq added the bug label Nov 2, 2021
@mwleeds mwleeds mentioned this issue Nov 2, 2021
Open
mwleeds added a commit that referenced this issue Nov 2, 2021
@mwleeds
search: Don't strip .desktop suffix overzealously
a7423a7 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes #4535
mwleeds added a commit that referenced this issue Nov 2, 2021
@mwleeds
search: Don't strip .desktop suffix overzealously
d3a3a0a 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes #4535
@mwleeds mwleeds mentioned this issue Nov 2, 2021
Merged
@mwleeds
Copy link
Collaborator

mwleeds commented Nov 2, 2021

Thanks for the bug report. Fix available in #4536

mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 10, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
98ba733 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.
mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 10, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
3f4d211 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 10, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
fb1f4cb 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 10, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
ab1efe8 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 11, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
02cbc05 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
alexlarsson pushed a commit that referenced this issue Nov 15, 2021
@mwleeds @alexlarsson
search: Don't strip .desktop suffix overzealously
62e09b4 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes #4535
mwleeds added a commit to pwithnall/flatpak that referenced this issue Nov 15, 2021
@mwleeds
search: Fix printing app ID with no .desktop suffix
e745f76 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
smcv pushed a commit to smcv/flatpak that referenced this issue Jan 4, 2022
@mwleeds @smcv
search: Don't strip .desktop suffix overzealously
5219dc8 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes flatpak#4535

(cherry picked from commit 62e09b4)
smcv pushed a commit to smcv/flatpak that referenced this issue Jan 4, 2022
@mwleeds @smcv
search: Don't strip .desktop suffix overzealously
385a457 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes flatpak#4535

(cherry picked from commit 62e09b4)
mwleeds added a commit that referenced this issue Jan 4, 2022
@mwleeds
search: Don't strip .desktop suffix overzealously
e916c84 
This commit changes the search command to properly output the app ID for
IDs that end in .desktop, e.g. to print org.telegram.desktop rather than
org.telegram.

Fixes #4535

(cherry picked from commit 62e09b4)
mwleeds added a commit to pwithnall/flatpak that referenced this issue Jan 27, 2022
@mwleeds
search: Fix printing app ID with no .desktop suffix
ebced6a 
In flatpak#4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes flatpak#4535
mwleeds added a commit that referenced this issue Feb 17, 2022
@mwleeds
search: Fix printing app ID with no .desktop suffix
2af0c17 
In #4535 it was brough to light
that the search command strips the ".desktop" suffix from app IDs even
if they genuinely end in .desktop. This commit fixes the reverse issue
now that we've ported to libappstream: don't include the .desktop suffix
even if it's present in the id of the appstream component, which it
sometimes is.

Fortunately we already ignore any components that don't have flatpak
<bundle> elements, so we can unambiguously get the ID there.

Fixes #4535
@chrisawi chrisawi mentioned this issue Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

search: Don't strip .desktop suffix overzealously flatpak/flatpak
2 participants
@cobratbq @mwleeds