Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: Add API to allow for persistence on RemoteDesktop sessions #128

Merged

Conversation

whot
Copy link
Contributor

@whot whot commented Oct 9, 2023

Same as the ScreenCast API

Fixes #127

cc @jadahl

Marking as Draft until I've sold off the right to rename this to a more sensible function name to the highest bidder. Any suggestions?

@GeorgesStavracas
Copy link
Member

libportal is not API nor ABI stable, so I'd be okay with breaking API for the next stable release.

For now, I guess a _full variant of this function should be enough

@jadahl
Copy link

jadahl commented Oct 14, 2023

libportal is not API nor ABI stable, so I'd be okay with breaking API for the next stable release.

Has that been the case always? If that's the case, how can libportal be suitable for any application that intends to be both distributable via Flatpak and traditional distributions?

@GeorgesStavracas
Copy link
Member

Has that been the case always?

That's how I've been approaching libportal development since at least 2021 🙂

If that's the case, how can libportal be suitable for any application that intends to be both distributable via Flatpak and traditional distributions?

Personally, I consider libportal suitable for Flatpak applications only... somewhat like a Rust / cargo dependency, you have to pinpoint the exact version you want in the manifest.

@whot whot force-pushed the wip/remote-desktop-restore-token branch from ccbcac3 to 4233151 Compare October 18, 2023 05:56
@whot whot force-pushed the wip/remote-desktop-restore-token branch from 4233151 to 8210d54 Compare October 18, 2023 05:58
@whot
Copy link
Contributor Author

whot commented Oct 18, 2023

Renamed to _full and tests updated and one extra new test added, should be ready.

@whot whot marked this pull request as ready for review October 18, 2023 05:59
@GeorgesStavracas GeorgesStavracas merged commit 585f687 into flatpak:main Oct 18, 2023
9 checks passed
@jadahl
Copy link

jadahl commented Oct 18, 2023

That's how I've been approaching libportal development since at least 2021 🙂

That is not what I would have assumed. Anyway, filed #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No API to create persistent RemoteDesktop sessions
3 participants