Introspection #54
Merged
Introspection #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIR will complain about it.
Without it, GIR thinks these are strings, instead of string arrays.
It's necessary for the visibility of the get_type()s generated by gnome.mkenum().
No functional changes, but will make next commit's diff a bit easier to read.
G_DECLARE_*_TYPE() already gives us the get_type() function of the object, declaring it again confuses the introspection scanner.
It's a necessary offering to the greater GIR gods.
No functional change, just will make things easier to deal with later.
GeorgesStavracas
force-pushed
the
gbsneto/introspection
branch
3 times, most recently
from
99ba63c
to
fa4168a
Compare
TingPing
reviewed
Nov 8, 2021
TingPing
approved these changes
Nov 8, 2021
Add instrospection to libportal, libportal-gtk3, and libportal-gtk4. Use Xdp as the namespace. Fixes flatpak#32
GeorgesStavracas
force-pushed
the
gbsneto/introspection
branch
from
fa4168a
to
f456e41
Compare
TingPing
reviewed
Nov 8, 2021
|
We will want a CI setup for the gtk4 backend at some point too. |
This is in my queue already - together with generating Flatpak bundles out of the manifests here. But I'll do it in a separate pull request. |
To exercise the newly introduced introspection, rewrite the GTK4 test in JavaScript / GJS, and rearrange the build files accordingly. Sadly, I had to drop the POSIX file write test, since that's not supported on JavaScript. This can still be tested using the GTK3 test.
Doesn't hurt to be slightly more up-to-date.
GeorgesStavracas
force-pushed
the
gbsneto/introspection
branch
from
f456e41
to
ab19e66
Compare
|
Bootstrapping the CI changes at #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. Needed suffling to expose XdpParent to GIR, but overall seems like a decently small changeset.
Fixes #32