Fix prev/next year buttons in monthSelect (#2275) #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a needless restriction in the click handling logic on the monthSelect plugin's prev/next year buttons: * the prev. year button would only decrement the year after selecting January, and * the next year button would only increment the year after selecting December. It also adds a test to protect against regressions of this bug.
rlue
force-pushed
the
bugfix/monthSelect/inc-dec-year
branch
from
b2fd7f2
to
d93f163
Compare
|
great work @rlue, appreciate the unit test too 🚀 |
This was referenced Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a needless restriction in the click handling logic
on the monthSelect plugin's prev/next year buttons:
after selecting January, and
after selecting December.
It also adds a test to protect against regressions of this bug.
Additional commits
The bugfix is preceded by a commit that rearranges the test files to match the file structure of the source files they test.