Bug fix: error thrown and calendar UI broken by invalid input value when allowInput is true and allowInvalidPreload is true #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allowInput is true and allowInvalidPreload is true and user enters some invalid value into input, Flatpickr throws an error and calendar UI is broken, because of that error. This happens because there is invalid value in self.selectedDates (set by setSelectedDate() function), but code that is executed further in setDate() function assumes that all values in self.selectedDates are always valid Date objects. This fix adds two simple checks to make sure we are dealing wth Date objects before using Date methods. The error can be reproduced here: https://jsfiddle.net/yd07z3vo/1/
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Mar 21, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [flatpickr](https://flatpickr.js.org) ([source](https://togithub.com/chmln/flatpickr)) | [`4.6.10` -> `4.6.11`](https://renovatebot.com/diffs/npm/flatpickr/4.6.10/4.6.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chmln/flatpickr</summary> ### [`v4.6.11`](https://togithub.com/chmln/flatpickr/releases/v4.6.11) [Compare Source](https://togithub.com/chmln/flatpickr/compare/v4.6.10...v4.6.11) There was a bug with time selection since so much stuff got merged in. New tests have been added to prevent this from happening again. #### What's Changed - Fix [#​2419](https://togithub.com/chmln/flatpickr/issues/2419) breaking with altInput and altFormat Enabled by [@​mshibuya](https://togithub.com/mshibuya) in [flatpickr/flatpickr#2662 - Bug fix: error thrown and calendar UI broken by invalid input value when allowInput is true and allowInvalidPreload is true by [@​barszczmm](https://togithub.com/barszczmm) in [flatpickr/flatpickr#2650 #### New Contributors - [@​barszczmm](https://togithub.com/barszczmm) made their first contribution in [flatpickr/flatpickr#2650 **Full Changelog**: flatpickr/flatpickr@v4.6.10...v4.6.11 </details> --- ### Configuration 📅 **Schedule**: "every weekend" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2649
When
allowInputis true andallowInvalidPreloadis true and user enters some invalid value into input, Flatpickr throws an error and calendar UI is broken, because of that error. This happens because there is invalid value in self.selectedDates (set by setSelectedDate() function), but code that is executed further in setDate() function assumes that all values in self.selectedDates are always valid Date objects.This fix adds two simple checks to make sure we are dealing with Date objects before using Date methods.
The error can be reproduced here: https://jsfiddle.net/yd07z3vo/1/