Skip to content

Commit

Permalink
* Do not produce .elc temporary file when unnecessary (bug#48978)
Browse files Browse the repository at this point in the history
* lisp/emacs-lisp/bytecomp.el (byte-compile-file): Produce .elc
temporary files only when non native compiling or when native
compiling but `byte+native-compile' is non nil.
  • Loading branch information
AndreaCorallo committed Jun 14, 2021
1 parent 8f2f91f commit 663fb3b
Showing 1 changed file with 14 additions and 15 deletions.
29 changes: 14 additions & 15 deletions lisp/emacs-lisp/bytecomp.el
Original file line number Diff line number Diff line change
Expand Up @@ -2067,16 +2067,17 @@ See also `emacs-lisp-byte-compile-and-load'."
(insert "\n") ; aaah, unix.
(cond
((null target-file) nil) ;We only wanted the warnings!
((or byte-native-compiling
(and (file-writable-p target-file)
;; We attempt to create a temporary file in the
;; target directory, so the target directory must be
;; writable.
(file-writable-p
(file-name-directory
;; Need to expand in case TARGET-FILE doesn't
;; include a directory (Bug#45287).
(expand-file-name target-file)))))
((and (or (null byte-native-compiling)
(and byte-native-compiling byte+native-compile))
(file-writable-p target-file)
;; We attempt to create a temporary file in the
;; target directory, so the target directory must be
;; writable.
(file-writable-p
(file-name-directory
;; Need to expand in case TARGET-FILE doesn't
;; include a directory (Bug#45287).
(expand-file-name target-file))))
;; We must disable any code conversion here.
(let* ((coding-system-for-write 'no-conversion)
;; Write to a tempfile so that if another Emacs
Expand Down Expand Up @@ -2105,11 +2106,9 @@ See also `emacs-lisp-byte-compile-and-load'."
;; recompiled). Previously this was accomplished by
;; deleting target-file before writing it.
(if byte-native-compiling
(if byte+native-compile
;; Defer elc final renaming.
(setf byte-to-native-output-file
(cons tempfile target-file))
(delete-file tempfile))
;; Defer elc final renaming.
(setf byte-to-native-output-file
(cons tempfile target-file))
(rename-file tempfile target-file t)))
(or noninteractive
byte-native-compiling
Expand Down

0 comments on commit 663fb3b

Please sign in to comment.