Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/bookmarks.rb: search bookmark file in XDG_CONFIG_HOME, then in HOME #10

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

jreybert
Copy link

search bookmark file first in XDG_CONFIG_HOME directory, then in HOME

search paths are stored in an array, making it easy to extend

rescue Errno::ENOENT
@bookmarks = {}
rescue
raise "Can't load configuration file"
raise "Can't save configuration file #{@@BOOKMARKS_PATH}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this message? This part of the code is actually loading the bookmarks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, typo...

search bookmark file first in XDG_CONFIG_HOME directory, then in HOME

search paths are stored in an array, making it easy to extend
@jreybert
Copy link
Author

I updated the patch to fix the typo.

flavio added a commit that referenced this pull request Sep 22, 2015
lib/bookmarks.rb: search bookmark file in XDG_CONFIG_HOME, then in HOME
@flavio flavio merged commit 7356f0b into flavio:master Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants