Fix and test case for href with unicode in it (Ruby 1.9.2). #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with some RSS feeds and feedzirra. Encoding::CompatibilityError: incompatible encoding regexp match (ASCII-8BIT regexp with UTF-8 string) loofah/lib/loofah/html5/scrub.rb:20:in `gsub' loofah/lib/loofah/html5/scrub.rb:20:in `block in scrub_attributes' loofah/lib/loofah/html5/scrub.rb:11:in `each' loofah/lib/loofah/html5/scrub.rb:11:in `scrub_attributes' loofah/lib/loofah/scrubber.rb:95:in `html5lib_sanitize' loofah/lib/loofah/scrubbers.rb:98:in `scrub' loofah/lib/loofah/scrubber.rb:108:in `traverse_conditionally_top_down' loofah/lib/loofah/scrubber.rb:78:in `traverse' loofah/lib/loofah/instance_methods.rb:46:in `scrub!' loofah/lib/loofah/instance_methods.rb:54:in `block in scrub!' .rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:239:in `block in each' .rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:238:in `upto' .rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:238:in `each' loofah/lib/loofah/instance_methods.rb:54:in `scrub!' loofah/lib/loofah/instance_methods.rb:44:in `scrub!' loofah/lib/loofah.rb:52:in `scrub_fragment' loofah/test/html5/test_sanitizer.rb:16:in `test_unicode_quote' .rvm/gems/ruby-1.9.2-p180/gems/mocha-0.9.12/lib/mocha/integration/mini_test/version_142_to_172.rb:27:in `run'
|
Thanks for this! I'll pull it in (with some small changes) this week. |
flavorjones
added a commit
that referenced
this pull request
Aug 8, 2011
|
Fix is in 1.1.0, just released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with parsing UTF-8 encoded attributes. Problem encountered with some RSS feeds and feedzirra.
Encoding::CompatibilityError: incompatible encoding regexp match (ASCII-8BIT regexp with UTF-8 string)
loofah/lib/loofah/html5/scrub.rb:20:in
gsub' loofah/lib/loofah/html5/scrub.rb:20:inblock in scrub_attributes'loofah/lib/loofah/html5/scrub.rb:11:in
each' loofah/lib/loofah/html5/scrub.rb:11:inscrub_attributes'loofah/lib/loofah/scrubber.rb:95:in
html5lib_sanitize' loofah/lib/loofah/scrubbers.rb:98:inscrub'loofah/lib/loofah/scrubber.rb:108:in
traverse_conditionally_top_down' loofah/lib/loofah/scrubber.rb:78:intraverse'loofah/lib/loofah/instance_methods.rb:46:in
scrub!' loofah/lib/loofah/instance_methods.rb:54:inblock in scrub!'.rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:239:in
block in each' .rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:238:inupto'.rvm/gems/ruby-1.9.2-p180/gems/nokogiri-1.4.4/lib/nokogiri/xml/node_set.rb:238:in
each' loofah/lib/loofah/instance_methods.rb:54:inscrub!'loofah/lib/loofah/instance_methods.rb:44:in
scrub!' loofah/lib/loofah.rb:52:inscrub_fragment'loofah/test/html5/test_sanitizer.rb:16:in
test_unicode_quote' .rvm/gems/ruby-1.9.2-p180/gems/mocha-0.9.12/lib/mocha/integration/mini_test/version_142_to_172.rb:27:inrun'