Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hashed refresh tokens #57

Merged
merged 7 commits into from
Dec 8, 2018
Merged

Conversation

mongkok
Copy link
Member

@mongkok mongkok commented Dec 4, 2018

Hash refresh tokens before save:

import hashlib

from django.db.models.signals import pre_save
from django.dispatch import receiver

from graphql_jwt.settings import jwt_settings


@receiver(pre_save, sender=jwt_settings.JWT_REFRESH_TOKEN_MODEL)
def hash_refresh_token(sender, instance, **kwargs):
    if not instance.pk:
        instance.token = hashlib.sha512(instance.token.encode()).hexdigest()

Hash refresh tokens before get instances:

import hashlib

from graphql_jwt.refresh_token.utils import get_refresh_token_by_model


def get_refresh_token(refresh_token_model, token, context=None):
    token = hashlib.sha512(token.encode()).hexdigest()
    return get_refresh_token_by_model(refresh_token_model, token, context)

Configure JWT settings:

GRAPHQL_JWT = {
    'JWT_VERIFY_EXPIRATION': True,
    'JWT_LONG_RUNNING_REFRESH_TOKEN': True,
    'JWT_GET_REFRESH_TOKEN_HANDLER': 'mysite.get_refresh_token',
}

Edit: renamed handler function

@codecov-io
Copy link

codecov-io commented Dec 4, 2018

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #57   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         331    275   -56     
  Branches       40     30   -10     
=====================================
- Hits          331    275   -56
Impacted Files Coverage Δ
graphql_jwt/refresh_token/shortcuts.py 100% <100%> (ø) ⬆️
...t/refresh_token/management/commands/cleartokens.py 100% <100%> (ø) ⬆️
graphql_jwt/refresh_token/models.py 100% <100%> (ø) ⬆️
graphql_jwt/refresh_token/utils.py 100% <100%> (ø)
graphql_jwt/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f141b46...631c97c. Read the comment docs.

@mongkok mongkok force-pushed the feature/allow-hashed-refresh-tokens branch from efb6ce2 to 9ad8887 Compare December 6, 2018 03:21
@mongkok mongkok merged commit 82be0dd into master Dec 8, 2018
@mongkok mongkok deleted the feature/allow-hashed-refresh-tokens branch August 11, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants