-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify input behaviour #27
Merged
philtweir
merged 9 commits into
release/0.9.1
from
feat/26-clarify-feedback-input-1-16-1-17
Jun 22, 2024
Merged
Clarify input behaviour #27
philtweir
merged 9 commits into
release/0.9.1
from
feat/26-clarify-feedback-input-1-16-1-17
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philtweir
force-pushed
the
feat/26-clarify-feedback-input-1-16-1-17
branch
from
June 3, 2024 18:30
3690794
to
5e76712
Compare
philtweir
force-pushed
the
feat/26-clarify-feedback-input-1-16-1-17
branch
from
June 3, 2024 18:32
5e76712
to
3b5a38b
Compare
elleryames
reviewed
Jun 9, 2024
elleryames
reviewed
Jun 9, 2024
elleryames
reviewed
Jun 9, 2024
elleryames
reviewed
Jun 10, 2024
The import of |
I understand that this PR introduces a new concept of |
This was referenced Jun 12, 2024
philtweir
changed the title
[Requires #25] Clarify input behaviour
Clarify input behaviour
Jun 22, 2024
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fundamental problem it solves is that, as per feedback, when a raw value is passed as an argument to a function, it should not simply be captured as a default value for that function call, but be turned into a global parameter. However, this behaviour does not make sense for raw (literal) variables inside tasks/nested tasks. In practice, this turned out to be quite a major change with a number of corner cases.
Consequently, this PR includes the following:
How to test?
Run through the documented workflows in the
docs
folder, and ensure they make sense with the input code.Who can review?
@elleryames or @KamenDimitrov97