refactor!: multiple fixes & additions to NetworkTileProvider (and underlying ImageProvider)
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…till being loaded Improved error handling Improved performance Added `silenceExceptions` parameter Reduced internal code duplication Removed lint that was often overridden
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
josxha
JaffaKetchup
added a commit
to fleaflet/flutter_map_cancellable_tile_provider
that referenced
this pull request
Dec 1, 2023
Improved internal structure
Strengthened test suite
JaffaKetchup
changed the title
NetworkTileProvider and custom ImageProviderNetworkTileProvider and custom ImageProvider
JaffaKetchup
added a commit
to fleaflet/flutter_map_cancellable_tile_provider
that referenced
this pull request
Dec 2, 2023
josxha
approved these changes
Dec 6, 2023
JaffaKetchup
force-pushed
the
improve-image-provider
branch
from
c4df50e
to
13e108f
Compare
JaffaKetchup
changed the title
NetworkTileProvider and custom ImageProviderNetworkTileProvider and custom ImageProvider
JaffaKetchup
changed the title
NetworkTileProvider and custom ImageProviderNetworkTileProvider (and underlying ImageProvider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1698 (and fixes #1703) as much as possible.
This transitions to a more consistent internal implementation of the
FlutterMapNetworkImageProvider, both in that it uses the same asynchronous styles throughout, and follows roughly what is recommended by theImageProviderdocumentation.It also fixes a bug or two, and aims to improve performance as much as is feasibly possible - however, because we cannot depend on dart:io without a lot of extra code, we cannot use some efficiency methods such as
consolidate...whatever, but I think there'll be little differences with the tiny images of tiles. An option has been added to just ignore exceptions in the HTTP IO portion of the image provider.This will be reflected in the
CancellableNetworkTileProviderin its v2, by PR fleaflet/flutter_map_cancellable_tile_provider#4.