multi!: v2 prep & reflected changes from fleaflet/flutter_map#1742 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved internal structure
Changed naming and internal scopes/visibility to allow for future testing suite implementations
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
josxha
JaffaKetchup
changed the title
JaffaKetchup
changed the title
josxha
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fleaflet/flutter_map#1742 for more information.
Note that this is prepared for a v2 release (in front of the v7 FM release). It does not depend on FM in any way that updating this library's FM dependency to v7 will require a breaking release - it is safe (with the current v7 plans) to release only a patch release to enable this library to support FM v7 on its release.