Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect profile status on re-enrolled ADE host #17243

Closed
sabrinabuckets opened this issue Feb 28, 2024 · 6 comments
Closed

Incorrect profile status on re-enrolled ADE host #17243

sabrinabuckets opened this issue Feb 28, 2024 · 6 comments
Assignees
Labels
~backend Backend-related issue. bug Something isn't working as documented bug-mac-encryption Defect in Mac encryption. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@sabrinabuckets
Copy link
Contributor

Fleet version: (head to the "My account" page in the Fleet UI or run fleetctl --version)
fleetctl - version fleetd-chrome-v1.2.0-beta-83-g48f1ea994
branch: main
revision: 48f1ea9
build date: 2024-02-28
build user: bri
go version: go1.22.0

Operating system: (e.g. macOS 11.2.3)
macOS (observed on 13 & 14)

Web browser: (e.g. Chrome 88.0.4324)
NA


📝 Description

Erasing and re-enrolling a host without deleting the host record from Fleet results in the DB entry not being reset, causing all profiles to report as Verified (or whatver status they were previously in.

Deleting the host record resolves this, whether done before or after enrollment.

👣 Reproduction steps

  1. Enroll an ADE-eligible host, enforce disk encryption and deploy any config profiles
  2. Confirm that all profiles are Verified
  3. Erase all content and settings
  4. Complete re-enrollment
  5. Open Host details or My Device page

🧑‍💻  Expected behavior

Host will enroll with disk encryption reporting Off, profiles will go through Pending > Verifying > Verified flow

💥  Actual behavior

All profiles display Verified status, Disk encryption state sometimes displays On despite encryption flow not yet completing.

User is still required to complete encryption flow on restart/logout, however no banner is present.

More info

This does not impact manually re-enrolled hosts. When the MDM profile is manually removed from the host the profile statuses clear.

Note - in some of my tests, disk encryption state did correctly show as Off, but this was inconsistent.

@sabrinabuckets sabrinabuckets added bug Something isn't working as documented :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release. #g-mdm MDM product group bug-mac-encryption Defect in Mac encryption. :incoming New issue in triage process. labels Feb 28, 2024
@nonpunctual
Copy link
Contributor

nonpunctual commented Feb 28, 2024

@sabrinabuckets So, here's my 2 ¢ on this:

Lots of orgs that started w Jamf years ago did not have other systems for device data. This meant Jamf data as a "source of truth" for the org was important (think schools, small / med bz)

Now, lots of orgs have lots of tools: ServiceNow for SAM & HAM, a million other integrations, so, the MDM's capability as an "archive" (MDM servers are kind of bad actually at tracking device history over time, but, good at showing the state right now) isn't as important.

I think Fleet should be modern & wipe out the record when a device re-enrolls. It is almost always the behavior that I wanted as an admin: nuke & pave. But, because jamf was built with the idea of preserving the device record on re-enroll, lots of other MDMs follow.

We could have an option for the admin to set so records are NOT wiped from previous enrollment records if that's what they want, but, imo, enrollments should always be new by default. Thanks. Thoughts?

@roperzh
Copy link
Member

roperzh commented Feb 29, 2024

@georgekarrv is this something we should loop Noah/Marko in ? asking to not start working on it otherwise

@georgekarrv georgekarrv added :product Product Design department (shows up on 🦢 Drafting board) and removed :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels Feb 29, 2024
@noahtalerman
Copy link
Member

Noah: Expected behavior is for wiped/erased host to have a fresh host record when it re-enrolls to Fleet.

@noahtalerman noahtalerman added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels Mar 1, 2024
@lukeheath lukeheath added this to the 4.47.0-tentative milestone Mar 1, 2024
@georgekarrv
Copy link
Member

TODO schedule a meeting to discuss all of the workflows and expected results.

1 similar comment
@georgekarrv
Copy link
Member

TODO schedule a meeting to discuss all of the workflows and expected results.

@georgekarrv georgekarrv removed the :incoming New issue in triage process. label Mar 11, 2024
@georgekarrv georgekarrv removed their assignment Mar 11, 2024
@lukeheath lukeheath modified the milestones: 4.47.0, 4.48.0-tentative Mar 11, 2024
@georgekarrv georgekarrv added the ~backend Backend-related issue. label Mar 11, 2024
@roperzh roperzh self-assigned this Apr 2, 2024
@georgekarrv georgekarrv modified the milestones: 4.50.0-tentative, 4.49.2 Apr 29, 2024
roperzh added a commit that referenced this issue Apr 29, 2024
The mantra for MDM lifecycle events is:

> - Noah: When MDM is turned on, install fleetd, bootstrap package (if
DEP),
> and profiles. Don't clear host vitals (everything you see on the Host
>      details page)
>    - Noah: On re-enrollment, don't clear host vitals.
>    - Noah: On lock and wipe, don't clear host vitals.
>    - Noah: On delete, clear host vitals.

This addresses issues:

- #17243
- #17481
- #17292
- #18030
- #18031
georgekarrv pushed a commit that referenced this issue Apr 30, 2024
The mantra for MDM lifecycle events is:

> - Noah: When MDM is turned on, install fleetd, bootstrap package (if
DEP),
> and profiles. Don't clear host vitals (everything you see on the Host
>      details page)
>    - Noah: On re-enrollment, don't clear host vitals.
>    - Noah: On lock and wipe, don't clear host vitals.
>    - Noah: On delete, clear host vitals.

This addresses issues:

- #17243
- #17481
- #17292
- #18030
- #18031
@fleet-release
Copy link
Contributor

In cloud city's heart,
Profiles reset, host reborn,
Fleet's truth shines anew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~backend Backend-related issue. bug Something isn't working as documented bug-mac-encryption Defect in Mac encryption. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Development

No branches or pull requests

8 participants