Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fleet Desktop to support a different display number on Ubuntu hosts #17660

Closed
7 of 11 tasks
noahtalerman opened this issue Mar 15, 2024 · 9 comments · Fixed by #18996
Closed
7 of 11 tasks

Update Fleet Desktop to support a different display number on Ubuntu hosts #17660

noahtalerman opened this issue Mar 15, 2024 · 9 comments · Fixed by #18996
Assignees
@noahtalerman
Labels
customer-honoria customer-reedtimmer :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Mar 15, 2024 •
edited
Loading

Goal

User story
As an endpoint operator who has Ubuntu (Linux) hosts w/ DISPLAY set to :1,
I want to see the Fleet Desktop icon
so that I can get to the My device page.

Changes

Product

Engineering

  • Database schema migrations: TODO
  • Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@noahtalerman noahtalerman added story A user story defining an entire feature customer-honoria customer-reedtimmer ~feature fest Will be reviewed at next Feature Fest labels Mar 15, 2024
@noahtalerman noahtalerman changed the title Update Fleet Desktop to support DISPLAY :1 on Ubuntu hosts Update Fleet Desktop to support a different display number on Ubuntu hosts Mar 15, 2024
noahtalerman added a commit that referenced this issue Mar 15, 2024
@noahtalerman
Update Supported-host-operating-systems.md
ddeda2f 
For the following bug: #12334

- Call out that, currently on Ubuntu, Fleet Desktop only supports display number of `0`

We tracked a separate [user story here](#17660) to add support for other display numbers (ex. `1`).
This was referenced Mar 15, 2024
Closed
Merged
@noahtalerman noahtalerman self-assigned this Mar 28, 2024
@noahtalerman
Copy link
Member Author

We discussed this request at feature fest.

We decided not to draft this one in the upcoming design sprint (4.49).

Removing from feature fest board.

@noahtalerman noahtalerman removed their assignment Mar 29, 2024
@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label Mar 29, 2024
@pintomi1989
Copy link
Contributor

Customer-honoria update: Linux usage is small, easy to overcome

@lucasmrod lucasmrod mentioned this issue May 13, 2024
Closed
@noahtalerman
Copy link
Member Author

Lucas from #18925:
After disabling Wayland (and using X11 instead, which is what Ubuntu < 24.04 are using), it seems the DISPLAY environment variable is :1 (fleetd assumes :0). Which is the reason clicking on My device/Transparency doesn't work.

So, we could provide (with minimal code changes) a workaround for Ubuntu 24.04 by allowing users to set a specific display variable (as defined in #17660) e.g. fleetctl package --override-display=:1 and ORBIT_OVERRIDE_DISPLAY=:1.

@lucasmrod lucasmrod mentioned this issue May 14, 2024
Merged
5 tasks
lucasmrod added a commit that referenced this issue May 16, 2024
@lucasmrod
Support Ubuntu 24.04 with Xorg (by detecting user's DISPLAY environ…
bb310e6 
…ment variable) (#18996)

#18925 (Should also fix #17660.)

Tests:
- Ubuntu 22.04.2
	- Wayland
		- Works with chrome ✅ 
		- Doesn't work with Firefox. ❌
	- Xorg
		- Works with Chrome. ✅ 
		- Works with Firefox. ✅
- Ubuntu 24.04
	- Wayland
		- Doesn't work with Chrome. ❌
		- Doesn't work with Firefox. ❌
- Xorg (when using Xorg it defaults to `DISPLAY=:1`, and with the
changes in this PR it works):
		- Works with Chrome. ✅ 
		- Works with Firefox. ✅ 
---

How to change between Wayland and Xorg:

- Set `WaylandEnable=false` in `/etc/gdm3/custom.conf` and reboot.

---

How to determine what's running:
```sh
$ loginctl
SESSION  UID USER SEAT  TTY 
      2 1000 luk  seat0 tty2
     c2 1000 luk        

$ loginctl show-session 2 -p Type
# will output
Type=wayland
or
Type=x11
```
---

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [X] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
@fleet-release
Copy link
Contributor

Ubuntu hosts shine,
Fleet Desktop icon gleams,
Path to device, streamlined.

@lucasmrod
Copy link
Member

(Reopening, was closed automatically by Github.)

@lucasmrod lucasmrod reopened this May 16, 2024
@lucasmrod lucasmrod self-assigned this May 16, 2024
@lucasmrod
Copy link
Member

@noahtalerman This change was released in fleetd 1.25.0 released on May 22nd.

@noahtalerman
Copy link
Member Author

@lucasmrod thanks!

Bringing this to the confirm and celebrate rituals: https://fleetdm.com/handbook/product-design#rituals

@noahtalerman noahtalerman added the :product Product Design department (shows up on 🦢 Drafting board) label Aug 27, 2024
@lucasmrod lucasmrod self-assigned this Aug 27, 2024
@noahtalerman
Copy link
Member Author

Hey @zayhanlon and @Patagonia121, heads up that this customer request was shipped on May 22nd.

@fleet-release
Copy link
Contributor

Ubuntu hosts shine,
Fleet desktop in clear view,
Device page in line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahtalerman noahtalerman

Labels
customer-honoria customer-reedtimmer :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Ubuntu 24.04 with Xorg (by detecting user's DISPLAY environment variable) fleetdm/fleet
5 participants
@lucasmrod @lukeheath @noahtalerman @fleet-release @pintomi1989