Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal background scrollbars showing up when no scroll necessary #19422

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix modal background scrollbars showing up when no scroll necessary #19422

merged 2 commits into from
May 31, 2024

Conversation

jacobshandling
Copy link
Contributor

Addresses #19284

Screenshot-2024-05-24-at-21725PM

  • Changes file added for user-visible changes in changes/, .
  • Manual QA for all new/changed functionality

@jacobshandling jacobshandling requested a review from a team as a code owner May 31, 2024 17:30
RachelElysia
RachelElysia approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Nice! I did a quick spot check for bugs related to setting this to auto and I don't see any.

@jacobshandling jacobshandling merged commit 4571b54 into main May 31, 2024
6 checks passed
@jacobshandling jacobshandling deleted the fix-modal-bg-scroll branch May 31, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachelElysia RachelElysia RachelElysia approved these changes

Assignees

@RachelElysia RachelElysia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobshandling @RachelElysia