Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

White scrollbars always appear on modal backgrounds #19284

Closed
jacobshandling opened this issue May 24, 2024 · 1 comment
Closed

White scrollbars always appear on modal backgrounds #19284

jacobshandling opened this issue May 24, 2024 · 1 comment
Assignees
@jacobshandling
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.51.0

Comments

@jacobshandling
Copy link
Contributor

Screenshot 2024-05-24 at 2.20.07 PM.png
@jacobshandling jacobshandling added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~frontend Frontend-related issue. ~released bug This bug was found in a stable release. labels May 24, 2024
@jacobshandling jacobshandling self-assigned this May 24, 2024
@jacobshandling jacobshandling mentioned this issue May 24, 2024
Merged
2 tasks
jacobshandling added a commit that referenced this issue May 28, 2024
@jacobshandling
UI – Activity feed webhook automation modal (#19285)
a5ab221 
_This PR is the direct-to-`main` replacement for #19096, which merged to
a now-defunct feature branch_

## Addresses #19052 

- update config, webhook interfaces, mock
- clean up deprecated Sandbox code
- implement Activity Feed Automations Modal and associated logic
- Also addresses #19284 

![Screenshot-2024-05-24-at-21725PM](https://github.com/fleetdm/fleet/assets/61553566/1afc62f7-eeb3-49a8-a545-b971f2a19921)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@jacobshandling jacobshandling added this to the 4.51.0-tentative milestone May 30, 2024
@jacobshandling jacobshandling mentioned this issue May 31, 2024
Merged
2 tasks
jacobshandling added a commit that referenced this issue May 31, 2024
@jacobshandling
Fix modal background scrollbars showing up when no scroll necessary (#…
4571b54 
…19422)

## Addresses #19284 

![Screenshot-2024-05-24-at-21725PM](https://github.com/fleetdm/fleet/assets/61553566/11b02fec-a91f-4156-b8f6-a5637f570834)

- [x] Changes file added for user-visible changes in `changes/`, .
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@fleet-release
Copy link
Contributor

Scrollbars turn to mist,
In modals, clarity reigns,
Fleet's canvas is crisp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.51.0
Development

No branches or pull requests
3 participants
@lukeheath @jacobshandling @fleet-release