MDM Azure enable scripts by default #19706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mna
approved these changes
Jun 17, 2024
roperzh
reviewed
Jun 17, 2024
| @@ -1353,7 +1353,7 @@ func (svc *Service) enqueueInstallFleetdCommand(ctx context.Context, deviceID st | |||
| <FileHash>9F89C57D1B34800480B38BD96186106EB6418A82B137A0D56694BF6FFA4DDF1A</FileHash> | |||
| </Validation> | |||
| <Enforcement> | |||
| <CommandLine>/quiet FLEET_URL="` + fleetURL + `" FLEET_SECRET="` + globalEnrollSecret + `"</CommandLine> | |||
| <CommandLine>/quiet FLEET_URL="` + fleetURL + `" FLEET_SECRET="` + globalEnrollSecret + `" ENABLE_SCRIPTS="True"</CommandLine> | |||
There was a problem hiding this comment.
sanity check: does this force us to update fleetd-base.msi before the release? or ENABLE_SCRIPTS will be safely ignored by older installers?
There was a problem hiding this comment.
I assume it will ignore unused parameters, but I will check to be sure
There was a problem hiding this comment.
Tested, additional parameters are just ignored
|
Hi folks! Missing changes file. |
|
@lucasmrod absolutely right, sorry about that. Fix incoming |
dantecatalfamo
added a commit
that referenced
this pull request
Jun 18, 2024
dantecatalfamo
added a commit
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17528