-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Linux ARM64 #19931
Add support for Linux ARM64 #19931
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19931 +/- ##
===========================================
- Coverage 62.65% 37.13% -25.53%
===========================================
Files 1405 1414 +9
Lines 131562 132740 +1178
Branches 3216 3216
===========================================
- Hits 82429 49289 -33140
- Misses 42810 79020 +36210
+ Partials 6323 4431 -1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Still awaiting code owners approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left some questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Almost there!
Just a couple of comments around the releaser.sh
script.
Also, double checking you have tested auto-updating orbit and Fleet Desktop to a "N+2" version, meaning these changes are not breaking the auto-update mechanism. IOW, you auto-update latest released orbit to an orbit version with the changes in this PR, then update some dummy string in orbit (to make the executable different) and push another update (effectively updating to a "N+2" version). Let me know if it makes sense. |
I haven't intentionally tested N+2, although while I'm working on orbit, I have a script that recompiles and pushes my changes to my local tuf server every time I save, and the client keeps updating without issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
https://github.com/fleetdm/fleet/actions/runs/9881234629/job/27291579818?pr=19931 looks like a network issue in the Github action, maybe try re-running the failed one? |
And https://github.com/fleetdm/fleet/actions/runs/9881234628/job/27291578960?pr=19931 is a known flaky test due to Colima timeouts in Github runners. |
Yeah the macos specific actions often have odd flaky issues |
Looks ready to merge, apparently pending one review |
#1845
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.