Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Linux ARM64 #19931

Merged
merged 56 commits into from
Jul 17, 2024
Merged

Add support for Linux ARM64 #19931

merged 56 commits into from
Jul 17, 2024

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Jun 21, 2024

#1845

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@dantecatalfamo dantecatalfamo marked this pull request as ready for review June 24, 2024 19:24
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 9.58904% with 66 lines in your changes missing coverage. Please review.

Project coverage is 37.13%. Comparing base (fceff75) to head (baf01f0).
Report is 75 commits behind head on main.

Files Patch % Lines
orbit/pkg/update/update.go 0.00% 29 Missing ⚠️
orbit/pkg/packaging/linux_shared.go 0.00% 15 Missing ⚠️
cmd/fleetctl/package.go 37.50% 10 Missing ⚠️
orbit/pkg/update/options.go 0.00% 6 Missing ⚠️
orbit/cmd/orbit/orbit.go 0.00% 5 Missing ⚠️
ee/fleetctl/updates.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19931       +/-   ##
===========================================
- Coverage   62.65%   37.13%   -25.53%     
===========================================
  Files        1405     1414        +9     
  Lines      131562   132740     +1178     
  Branches     3216     3216               
===========================================
- Hits        82429    49289    -33140     
- Misses      42810    79020    +36210     
+ Partials     6323     4431     -1892     
Flag Coverage Δ
backend 35.66% <9.58%> (-27.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mna
mna previously approved these changes Jul 8, 2024
@dantecatalfamo
Copy link
Member Author

Still awaiting code owners approval

roperzh
roperzh previously approved these changes Jul 10, 2024
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left some questions/comments.

cmd/fleetctl/package.go Outdated Show resolved Hide resolved
changes/1845-linux-arm64 Outdated Show resolved Hide resolved
orbit/pkg/packaging/packaging.go Outdated Show resolved Hide resolved
orbit/pkg/update/update.go Outdated Show resolved Hide resolved
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Almost there!

Just a couple of comments around the releaser.sh script.

@lucasmrod
Copy link
Member

Also, double checking you have tested auto-updating orbit and Fleet Desktop to a "N+2" version, meaning these changes are not breaking the auto-update mechanism.

IOW, you auto-update latest released orbit to an orbit version with the changes in this PR, then update some dummy string in orbit (to make the executable different) and push another update (effectively updating to a "N+2" version).

Let me know if it makes sense.

@dantecatalfamo
Copy link
Member Author

I haven't intentionally tested N+2, although while I'm working on orbit, I have a script that recompiles and pushes my changes to my local tuf server every time I save, and the client keeps updating without issue

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucasmrod
Copy link
Member

https://github.com/fleetdm/fleet/actions/runs/9881234629/job/27291579818?pr=19931 looks like a network issue in the Github action, maybe try re-running the failed one?

@lucasmrod
Copy link
Member

And https://github.com/fleetdm/fleet/actions/runs/9881234628/job/27291578960?pr=19931 is a known flaky test due to Colima timeouts in Github runners.

@dantecatalfamo
Copy link
Member Author

Yeah the macos specific actions often have odd flaky issues

@dantecatalfamo
Copy link
Member Author

Looks ready to merge, apparently pending one review

@dantecatalfamo dantecatalfamo merged commit ecf2346 into main Jul 17, 2024
37 checks passed
@dantecatalfamo dantecatalfamo deleted the linux-arm64 branch July 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants