combine osquery + mdm information for connected_to_fleet #20230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for #20057 this still leaves edge cases like a host that is reset to factory settings and doesn't install `fleetd` again, but this problem was already there even before we introduced `connected_to_fleet`
mna
approved these changes
Jul 8, 2024
| @@ -0,0 +1 @@ | |||
| * Improved the accuracy of the heuristic used to deterimine if a host is connected to Fleet via MDM by using osquery data for hosts that didn't send a Checkout message. | |||
There was a problem hiding this comment.
Suggested change
| * Improved the accuracy of the heuristic used to deterimine if a host is connected to Fleet via MDM by using osquery data for hosts that didn't send a Checkout message. | |
| * Improved the accuracy of the heuristic used to determine if a host is connected to Fleet via MDM by using osquery data for hosts that didn't send a Checkout message. |
There was a problem hiding this comment.
thank you! these go through chatgpt (😨) before they land the release notes so I'll leave it just so I don't lose your ✅ and have to bother you again + fight CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #20057
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.