Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TIDY3D_DIR configurable via environment variable #1132

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Make TIDY3D_DIR configurable via environment variable #1132

merged 2 commits into from
Aug 30, 2023

Conversation

yaugenst
Copy link
Contributor

Tries to read the TIDY3D_DIR environment variable to set tidy3d's base directory and defaults to the current behavior. Partially solves #1131 and is what I am currently using.

@momchil-flex
Copy link
Collaborator

Thanks. Actually we have a related PR #1100 in which the folder is set to /tmp/.tidy3d if ~/.tidy3d cannot be written into. That said we can also add the environment variable option. Note that currently this is only used for the api key, which can also be set through environment variable SIMCLOUD_APIKEY, in which case the config folder should not be needed.

@momchil-flex
Copy link
Collaborator

I just merged #1100 ; could you modify your PR to set the default folder as per that modification, when not provided as env variable? Thanks!

@yaugenst
Copy link
Contributor Author

Oh great thanks! I was aware of the api key variable, but thought it didn't work. Turns out I am bad at reading, I used SIMCLOUD_API_KEY...
That probably makes this PR obsolete for now, it might still be useful though if in the future there are more global configuration options planned.

@yaugenst
Copy link
Contributor Author

Changed the environment variable to TIDY3D_BASE_DIR to better reflect its purpose according to #1100.

@momchil-flex
Copy link
Collaborator

Thanks!

@momchil-flex momchil-flex merged commit 677ef55 into flexcompute:develop Aug 30, 2023
11 checks passed
@yaugenst yaugenst deleted the yaugenst/tidy3d_env_dir branch September 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants