Error if any frequencies are smaller than 1e5 Hz #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
approved these changes
Dec 4, 2023
momchil-flex
force-pushed
the
momchil/validators
branch
from
3280cd6
to
a7ae6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic change is very simple: previously, we only validated that
ModeSolver.freqsare larger than 1e5. Now we also do it for monitor frequencies, and source central frequency.However, this required quite a bit of tests changes since we were using frequencies of order 1 often. It's probably anyway better to fix this in tests too though...
I also removed all 1.x simulations that the updater was checking for. Some of the earlier ones had freqs of order 1 too. And in general, I don't think we still need to check compatibility with Tidy3D v1.