Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 branch #1315

Merged
merged 77 commits into from
Feb 21, 2024
Merged

2.6 branch #1315

merged 77 commits into from
Feb 21, 2024

Conversation

tylerflex
Copy link
Collaborator

No description provided.

@tylerflex tylerflex added the 2.6 label Dec 13, 2023
@tylerflex tylerflex marked this pull request as draft December 13, 2023 23:26
lucas-flexcompute and others added 27 commits December 18, 2023 07:49
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
The current error message suggests using a function in Trimesh that will be deprecated in March 2024, and using it now results in some weird errors. The alternative suggestion I'm works.
@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Feb 13, 2024

PRs that need to be merged only when the release is happening (in order):

  • Any final notebooks PRs onto pre/2.6 notebooks
  • Merge pre/2.6 notebooks into notebooks develop FEAT: 2.6 release tidy3d-notebooks#44
  • Notebooks update to links "latest" into notebooks develop FEAT: Update links to 2.6 absolute formatting tidy3d-notebooks#34
  • FAQ update to links to "latest" into develop FEAT: Update all links tidy3d-faq#12
  • Need to update submodules now on tidy3d frontend, both to develop, make sure docs build.
  • Then merge this PR
  • I've already made a backup of the tidy3d-docs/develop branch before it gets overwritten
  • Manually overwrite (force push) tidy3d into tidy3d-docs develop (this only ever has to be done once, and it's to erase the submodule state in the git index in the tidy3d-docs/develop branch that otherwise will cause problems, becasue the current action can't do that)

@tylerflex
Copy link
Collaborator Author

Just wondering, why would we need to wait until the release? Could we just merge everything into pre/2.6 as soon as available? (or would that update our displayed 2.6.0rc1 docs?)

@daquinteroflex
Copy link
Collaborator

So the problem is that the FAQs develop branch is linked to the helpcenter, which would break all links. For notebooks, actually true, I think I had the intention to check that any new notebooks had their links updated before the release. But we could do that in two PRs

@tylerflex
Copy link
Collaborator Author

ok, so this will only be an issue for 2.6? (not 2.7+?)

@daquinteroflex
Copy link
Collaborator

Yeah exactly, that's why thought to help out organizing the PR order

@momchil-flex momchil-flex marked this pull request as ready for review February 21, 2024 17:42
@momchil-flex momchil-flex merged commit 157d7da into develop Feb 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants