-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Urgent update ruff version fix 🏃 #1537
Conversation
026abdc
to
952f536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. but just wondering if we need to also apply ruff
to the code after this? I suppose that will cause a lot of merge conflicts potentially?
So we have two ways to approach this:
How do you think best to approach? Currently everyone may have different ruff versions which was causing issues with Marc I found. |
At some point, we should apply to the entire codebase. I guess the question is when is the 'best' time to do that? maybe right before we do an official 2.7.0 release could be one option? Another would be to just do it now and ask everyone to update their ruff. What do you think is best? |
It's kind of like when do we want to deal with this pain. It is most likely not at the end-period of a release, and I feel it'd be better towards the start of the release cycle. But I don't intentionally want to add extra suffering to people migrating really. I understand this will fix the ruff dependency management at least on the frontend, so depending how they've installed the precommit it should update. Backend is separate I think. |
maybe we could apply it to develop immediately after |
That makes sense! In any case, the pre-commit should make this progressive whenever people are using it. |
Will merge this in then, tomorrow morning |
I was helping out @marc-flex and realised that the
ruff
version was not fixed. This caused a bit of mayhem in the linting, and is relatively urgent. I believe progressively everyone migrating to this version until we decide to change it will occur file by file.