Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Urgent update ruff version fix 🏃 #1537

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

daquinteroflex
Copy link
Collaborator

I was helping out @marc-flex and realised that the ruff version was not fixed. This caused a bit of mayhem in the linting, and is relatively urgent. I believe progressively everyone migrating to this version until we decide to change it will occur file by file.

@daquinteroflex daquinteroflex marked this pull request as ready for review March 13, 2024 11:27
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. but just wondering if we need to also apply ruff to the code after this? I suppose that will cause a lot of merge conflicts potentially?

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Mar 13, 2024

So we have two ways to approach this:

  1. Either apply ruff soon for all files, and fix code that fails accordingly which I think is quite a bit. Update the pre/2.7 branch accordingly to avoid future conflcts.
  2. Fix this in the environment, but because the pre-commit only runs for the files that have been changed, then in each PR the ruff will be updating the files progressively.

How do you think best to approach?

Currently everyone may have different ruff versions which was causing issues with Marc I found.

@tylerflex
Copy link
Collaborator

At some point, we should apply to the entire codebase. I guess the question is when is the 'best' time to do that? maybe right before we do an official 2.7.0 release could be one option? Another would be to just do it now and ask everyone to update their ruff. What do you think is best?

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Mar 13, 2024

It's kind of like when do we want to deal with this pain. It is most likely not at the end-period of a release, and I feel it'd be better towards the start of the release cycle. But I don't intentionally want to add extra suffering to people migrating really.

I understand this will fix the ruff dependency management at least on the frontend, so depending how they've installed the precommit it should update. Backend is separate I think.

@tylerflex
Copy link
Collaborator

maybe we could apply it to develop immediately after 2.7.0 release? and before making pre/2.8? And also ask everyone to upgrade then? In the meantime just do the minimal changes (affecting the pre-commit)

@daquinteroflex
Copy link
Collaborator Author

That makes sense! In any case, the pre-commit should make this progressive whenever people are using it.

@daquinteroflex
Copy link
Collaborator Author

Will merge this in then, tomorrow morning

@daquinteroflex daquinteroflex merged commit 4602e19 into develop Mar 14, 2024
13 checks passed
@daquinteroflex daquinteroflex deleted the dario/fix_ruff_version branch March 14, 2024 10:21
@daquinteroflex daquinteroflex restored the dario/fix_ruff_version branch August 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants