Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trimesh version to >=4,<4.2 #1557

Merged
merged 1 commit into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Better error message when trying to transform a geometry with infinite bounds.

### Changed
- Bumped `trimesh` version to `>=4,<4.2`.

## [2.6.1] - 2024-03-07

### Added
Expand Down
2 changes: 1 addition & 1 deletion docs/faq
Submodule faq updated 227 files
19 changes: 10 additions & 9 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jax = [
# trimesh
networkx = {version = "^2.6.3", optional = true}
rtree = {version = "1.0.1", optional = true}
trimesh = {version = "3.20.0", optional = true}
trimesh = {version = ">=4,<4.2", optional = true}

# docs
jupyter = {version="*", optional = true}
Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/geometry/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ def intersections_tilted_plane(
if section is None:
return []
path, _ = section.to_planar(to_2D=to_2D)
return path.polygons_full.tolist()
return path.polygons_full

def intersections_plane(self, x: float = None, y: float = None, z: float = None):
"""Returns shapely geometry at plane specified by one non None value of x,y,z.
Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/geometry/mesh.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def intersections_tilted_plane(
if section is None:
return []
path, _ = section.to_planar(to_2D=to_2D)
return path.polygons_full.tolist()
return path.polygons_full

def intersections_plane(
self, x: float = None, y: float = None, z: float = None
Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/geometry/polyslab.py
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ def intersections_tilted_plane(
if section is None:
return []
path, _ = section.to_planar(to_2D=to_2D)
return path.polygons_full.tolist()
return path.polygons_full

def _intersections_normal(self, z: float):
"""Find shapely geometries intersecting planar geometry with axis normal to slab.
Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/geometry/primitives.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def intersections_tilted_plane(
if section is None:
return []
path, _ = section.to_planar(to_2D=to_2D)
return path.polygons_full.tolist()
return path.polygons_full

def _intersections_normal(self, z: float):
"""Find shapely geometries intersecting cylindrical geometry with axis normal to slab.
Expand Down
Loading