Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trimesh version to >=4,<4.2 #1557

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

caseyflex
Copy link
Contributor

@caseyflex caseyflex commented Mar 18, 2024

To restore compatibility with gdsfactory. Ran tests with trimesh=4.0.0 and trimesh=4.1.8.

@daquinteroflex can you take a look at poetry.lock? Something isn't right, I ran poetry update trimesh but it also changed python-versions and [package.extras].

@lucas-flexcompute can you take a look at the gds-related files to see if I missed anything?

@caseyflex caseyflex linked an issue Mar 18, 2024 that may be closed by this pull request
@caseyflex caseyflex marked this pull request as draft March 18, 2024 13:03
@caseyflex caseyflex added the 2.7 will go into version 2.7.* label Mar 18, 2024
@daquinteroflex
Copy link
Collaborator

Hi Casey, no worries, that looks about right! The pre v3 trimesh pyproject.toml didn't specify a minimum version, whereas the v4 does so poetry resolves this too. This applies too to the extras and so on. Also since the tests pass, and they run from the poetry environment, all is good!

@caseyflex
Copy link
Contributor Author

Hi Casey, no worries, that looks about right! The pre v3 trimesh pyproject.toml didn't specify a minimum version, whereas the v4 does so poetry resolves this too. This applies too to the extras and so on. Also since the tests pass, and they run from the poetry environment, all is good!

Nice, thanks for checking!

Copy link
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caseyflex !

@caseyflex caseyflex marked this pull request as ready for review March 18, 2024 16:00
@tylerflex
Copy link
Collaborator

Hey @caseyflex could you update the submodule commit. for docs/faq for this? It's currently failing

Checking docs/faq for updates...
Error: Submodule docs/faq is not up to date. Please update it.

@caseyflex
Copy link
Contributor Author

Hey @caseyflex could you update the submodule commit. for docs/faq for this? It's currently failing

Checking docs/faq for updates...
Error: Submodule docs/faq is not up to date. Please update it.

done!

@momchil-flex momchil-flex merged commit e04b4cd into pre/2.7 Mar 29, 2024
13 checks passed
@momchil-flex momchil-flex deleted the casey/upgradetrimesh branch March 29, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade trimesh requirement to 4.*
5 participants