Warning if a nonuniform custom medium is intersecting certain sources and monitors #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
force-pushed
the
weiliang/custom_medium_validation
branch
from
d2a7e6c
to
6589c52
Compare
weiliangjin2021
commented
Apr 8, 2024
weiliangjin2021
requested review from
tylerflex,
dbochkov-flexcompute and
momchil-flex
weiliangjin2021
force-pushed
the
weiliang/custom_medium_validation
branch
from
6589c52
to
20bcf0a
Compare
tylerflex
approved these changes
Apr 9, 2024
dbochkov-flexcompute
approved these changes
Apr 9, 2024
weiliangjin2021
force-pushed
the
weiliang/custom_medium_validation
branch
2 times, most recently
from
40aef78
to
50fc403
Compare
momchil-flex
approved these changes
May 1, 2024
tidy3d/components/simulation.py
Outdated
| f"{len(mediums)} different mediums detected on plane " | ||
| f"intersecting a {monitor.type}. Plane must be homogeneous." | ||
| ) | ||
| # if <=1 medium, check if the medium is spatially uniform |
There was a problem hiding this comment.
Is it possible to have 0 media? That kinda feels like something is wrong too, unless we're not taking the simulation background into account, but I think we are?
In other words not sure if we can remove the for mat in mediums and / or raise a different error if mediums is empty.
There was a problem hiding this comment.
It shouldn't be possible. An error has been raised now if 0 media.
tidy3d/components/simulation.py
Outdated
| "not supported." | ||
| ) | ||
|
|
||
| # if <=1 medium, check if the medium is spatially uniform |
There was a problem hiding this comment.
Same comment as above.
weiliangjin2021
force-pushed
the
weiliang/custom_medium_validation
branch
from
50fc403
to
f3f2b99
Compare
… and monitors Add is_spatially_uniform property to materials Add is_uniform property to data array and unstructured dataset
weiliangjin2021
force-pushed
the
weiliang/custom_medium_validation
branch
from
f3f2b99
to
e0af8d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1373