-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alec/remove converter #1658
Alec/remove converter #1658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. can we just squash these into a single commit please? and also merge into pre/2.7? thanks!
So I'm not authorized to merge this PR. Could I grab access? Then I'll do the squash-and-merge |
You'll need to rebase locally against pre/2.7 and then squash the commits there. You can change |
Gotcha, yeah I just realized that there's gonna be conflicts with this
method
…On Thu, May 2, 2024 at 11:33 AM Tyler Hughes ***@***.***> wrote:
You'll need to rebase locally against pre/2.7 and then squash the commits
there. You can change pick to fixup in the commit list for the bottom N-1
commits and it should work.
—
Reply to this email directly, view it on GitHub
<#1658 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBFS3WMYLIHJ6YGFW7OCHTLZAJMFNAVCNFSM6AAAAABHC47L3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQHAZDANRTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
d17ca82
to
7c24f37
Compare
1a631b6
to
5ce8350
Compare
I decided to add a CHANGELOG, and make the old command just error with a link to your new repo. Also added a test to ensure it worked properly. Occurred to me after the fact that we should do this, just in case people are confused by it disappearing. Will merge once tests pass. |
5ce8350
to
0f00e68
Compare
0f00e68
to
6f6dc03
Compare
No description provided.