Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alec/remove converter #1658

Merged
merged 1 commit into from
May 2, 2024
Merged

Alec/remove converter #1658

merged 1 commit into from
May 2, 2024

Conversation

alec-flexcompute
Copy link
Contributor

No description provided.

@alec-flexcompute alec-flexcompute marked this pull request as ready for review May 2, 2024 03:12
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can we just squash these into a single commit please? and also merge into pre/2.7? thanks!

@alec-flexcompute alec-flexcompute changed the base branch from develop to pre/2.7 May 2, 2024 15:29
@alec-flexcompute
Copy link
Contributor Author

So I'm not authorized to merge this PR. Could I grab access? Then I'll do the squash-and-merge

@tylerflex
Copy link
Collaborator

You'll need to rebase locally against pre/2.7 and then squash the commits there. You can change pick to fixup in the commit list for the bottom N-1 commits and it should work.

@alec-flexcompute
Copy link
Contributor Author

alec-flexcompute commented May 2, 2024 via email

@tylerflex
Copy link
Collaborator

I decided to add a CHANGELOG, and make the old command just error with a link to your new repo. Also added a test to ensure it worked properly.

Occurred to me after the fact that we should do this, just in case people are confused by it disappearing. Will merge once tests pass.

@tylerflex tylerflex merged commit a2f7e83 into pre/2.7 May 2, 2024
16 checks passed
@tylerflex tylerflex deleted the alec/remove_converter branch May 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants