-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side exact projections #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I have two comments that are not exactly related to the changes in the current PR, but they're something to think about in line with this ongoing refactoring.
Specifically, I do not like that in the resulting I thought about this and I realize that it's not straightforward to fix - I kinda understand why it is set up the way it is. But what about having a |
I think this covers all the remaining loose ends except that precision issue for very far exact projections, but I suggest you review these changes in parallel to my trying to fix that, since it's more on the math / technical side and shouldn't affect the design. |
b55266d
to
44c8836
Compare
- name change near2far to field projection and associated changes and additions to tests - made monitors mandatory in field projection data - integration surfaces and projection surfaces added - proj monitors now store projection surfaces - add a warning for exact projections for large distances - updated large distance handling and some docstrings
44c8836
to
5f43696
Compare
bool
switch in the monitors.Near2Far
->FieldProjection
everywhereBackend PR: https://github.com/flexcompute/tidy3d-core/pull/196