Iv 2077 proxy #16
Merged
Iv 2077 proxy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panics in websocket pinger should probably not ever be fatal
|
Code Coverage is 57.7%, details at https://s3.amazonaws.com/rs-code-coverage/wstunnel/2015-06-19_60_Coverage-57.7.txt (sometimes the URL can take a few minutes to be available) |
|
Code Coverage is 56.8%, details at https://s3.amazonaws.com/rs-code-coverage/wstunnel/2015-06-23_62_Coverage-56.8.txt (sometimes the URL can take a few minutes to be available) |
psschroeter
force-pushed
the
IV-2077_proxy
branch
from
7bbbae1
to
3bfa01c
Compare
|
Code Coverage is 57.6%, details at https://s3.amazonaws.com/rs-code-coverage/wstunnel/2015-06-23_64_Coverage-57.6.txt (sometimes the URL can take a few minutes to be available) |
| t.exitChan = make(chan struct{}, 1) | ||
| waitForConn := make(chan struct{}, 1) |
There was a problem hiding this comment.
I don't understand what this is doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tve, add HTTPS proxy support to tunnel.
Spec changes are not as extensive as they seem. Combined internal tests into basic tests as they were the same tests with a couple things tweaked. Did this by putting them into a function -- none of the content of the tests themselves was changed. The function is then run in different gomega Contexts with appropriate setup for each.