Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subunit integration #108

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Fix subunit integration #108

merged 5 commits into from
Jan 4, 2022

Conversation

ollipa
Copy link
Member

@ollipa ollipa commented Nov 16, 2021

I added tests for subunit integration and noticed it was broken. Patching subunit.test_results.TestResultDecorator seems to fix the integration.

Other changes:

  • Test that flexmock teardown works with doctest, pytest and testtools.

Related issue #68

tests/test_doctest.py Show resolved Hide resolved
tests/test_doctest.py Outdated Show resolved Hide resolved
tests/test_testtools.py Show resolved Hide resolved
@ollipa ollipa force-pushed the feature/test-doctest branch 2 times, most recently from cf30f22 to 43b9be8 Compare December 1, 2021 01:06
Base automatically changed from feature/test-doctest to master December 1, 2021 01:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #108 (5780dd3) into master (2940955) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   97.95%   97.83%   -0.12%     
==========================================
  Files           4        4              
  Lines         832      833       +1     
==========================================
  Hits          815      815              
- Misses         17       18       +1     
Impacted Files Coverage Δ
src/flexmock/_integrations.py 77.21% <100.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2940955...5780dd3. Read the comment docs.

Copy link
Contributor

@christophe-riolo christophe-riolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job there 👍

@ollipa ollipa merged commit bdd8cfe into master Jan 4, 2022
@ollipa ollipa deleted the feature/test-subunit branch January 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants