Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When user tried to open simulator which is already open using target launch he gets ungraceful error #1382

Closed
pauliusguzas opened this issue Feb 6, 2024 · 0 comments
Closed

When user tried to open simulator which is already open using target launch he gets ungraceful error #1382

pauliusguzas opened this issue Feb 6, 2024 · 0 comments
Assignees
@pavjacko
Labels
bug Something isn't working
Milestone
1.0

Comments

@pauliusguzas
Copy link
Collaborator

Describe the bug
When user tried to open simulator which is already open using target launch he gets ungraceful error

To Reproduce

  1. Go to template-starter package (or harness)
  2. Do npx rnv target launch -p ios -t valid_target -> command exits successfully but no sim is open
  3. Do same command again -> error appears which is expected but the error could be handled by rnv

Expected behavior
more graceful error

Desktop (please complete the following information):

  • OS: macOS Ventura 13.5.2
  • Node Version 18.19.0
  • RNV Version 1.0.0-rc.10
  • @rnv/template-starter 1.0.0-rc.10
@pauliusguzas pauliusguzas added the bug Something isn't working label Feb 6, 2024
@pauliusguzas pauliusguzas mentioned this issue Feb 6, 2024
Closed
@pavjacko pavjacko self-assigned this Feb 6, 2024
@pavjacko pavjacko added this to the 1.0 milestone Feb 6, 2024
@pavjacko pavjacko mentioned this issue Feb 6, 2024
Merged
pavjacko added a commit that referenced this issue Feb 6, 2024
@pavjacko
fixes #1382 (-p ios)
2d3fff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavjacko pavjacko

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@pavjacko @pauliusguzas