New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed webos CLI not finding index #1150

Merged

pavjacko merged 1 commit into main from fix/webos_html

Oct 10, 2023

Contributor

mihaiblaga89 commented Oct 9, 2023

Description

renative "version": "0.36.1" getting issue in webos build #964
fixed webos cli not finding index.html


          fixed webos CLI not finding index

3684ee1

github-advanced-security bot found potential problems

View reviewed changes

packages/sdk-webos/src/runner.ts

                   if (!c.program.hosted) {
-                      const tDir = getPlatformProjectDir(c);
+                      const tDir = path.join(getPlatformProjectDir(c)!, 'build');

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This path concatenation which depends on

library input

is later used in a

shell command

.

pavjacko approved these changes

View reviewed changes

pavjacko merged commit 8d2b938 into main

3 checks passed

pavjacko deleted the fix/webos_html branch

October 10, 2023 03:12

pavjacko added this to the 1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet