add rnv as dependency to template #1203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavjacko
requested changes
Oct 25, 2023
There was a problem hiding this comment.
we need to make rnv work without relying on template having its own bundled version of rnv. templates should not have any dependencies on their own as they are only used to generate actual dependencies in project. not following this rule can introduce lot of issues with duplicate dependencies (ie RN & its plugins_
|
@pavjacko moved dependency back, added it from rnv new task |
|
closing in favour of #1216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After
rnv newCLI says to executernv run. This will break core since there's gonna be a mismatch andnpx rnvwill not work anyway in this stateAdded rnv as a dependency to the template itself, that way
npx rnvwill work out of the box and avoid any core issues.