New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bonanza #1216
Fix Bonanza #1216
Conversation
…e into fix/rn_cli_version_fix
const extraGradleParams = getConfigProp(c, platform, 'extraGradleParams', ''); | ||
|
||
let command = `npx react-native build-android --mode=${signingConfig} --no-packager`; | ||
let command = `npx react-native build-android --mode=${signingConfig} --no-packager --tasks ${outputAab ? 'bundle' : 'assemble'}${signingConfig}`; |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
library input
shell command
fix targetSchema tvos + xcode group creation
@@ -635,7 +641,7 @@ | |||
} | |||
if (!ps.includes('-scheme')) { | |||
p.push('-scheme'); | |||
p.push(appFolderName); | |||
p.push(schemeTarget); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
library input
shell command
This shell argument which depends on
library input
shell command
Hello, I tried to install a fresh Renative install with this version : 1.0.0-feat-bonanza.4
Template: I am forced to use this template as all of the others seem to use react-native 0.67 which is not compatible with XCode 15 (Yoga does not compile) MacOS Version : 14.0 (23A344) (Sonoma) Command : Here is the log of the pod install :
|
@maximejen this PR is still work in progress but I'll make sure to check the issue you mentioned. Any additional steps on how to reproduce it or you just installed RNV globally, created a new project and ran |
Yes, I figured it was still a WIP basic steps are what I described Any ideas or ints on how I could fix that myself ? Changing the Podfile is useless as rnv overides it. |
@maximejen no, this should work, I haven't encountered the issue that you're facing at all. I see your log mentions
are you sure that's running RNV version 1? Can you post a full output maybe? |
Fix/androidwear manifest
Sorry for the delay, to install rnv I followed the documentation the 4 lines you gave me are in the output just before the like "pod install" in my case I can give you a full output later. I will look for a newer version of rnv looks like there is also a 1.0.0-feat-bonanza.4 for rnv, I am installing as I write this |
prevent the opening of a new terminal <= ios + tvos export
@maximejen then it makes sense. You're trying to use an older version of RNV with a newer template. Uninstall that version with |
pod install is running now, with rnv 1.0.0 etc.. Yeah I get that the version is unstable, but still, it's the only version I can run on my mac, since the Thanks for your fast answers 👍🏻 I'll do issues next time if I find anything that can be improved |
…nked mode running
…o/renative into feat/remove_metro_config
fix/kill_child_processes on exit
Extra fixes for bonanza
Description
Correct nextjs config in template [web] Web doesn't run on @rnv/template-starter@1.0.0-canary.7 #1208dynamic RN path for iOS buildscript [tvos, ios] export error #1211