Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bonanza #1216

Merged
merged 63 commits into from Nov 9, 2023
Merged

Fix Bonanza #1216

merged 63 commits into from Nov 9, 2023

Conversation

mihaiblaga89
Copy link
Member

@mihaiblaga89 mihaiblaga89 commented Oct 30, 2023

Description

const extraGradleParams = getConfigProp(c, platform, 'extraGradleParams', '');

let command = `npx react-native build-android --mode=${signingConfig} --no-packager`;
let command = `npx react-native build-android --mode=${signingConfig} --no-packager --tasks ${outputAab ? 'bundle' : 'assemble'}${signingConfig}`;

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
is later used in a
shell command
.
@@ -635,7 +641,7 @@
}
if (!ps.includes('-scheme')) {
p.push('-scheme');
p.push(appFolderName);
p.push(schemeTarget);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This shell argument which depends on
library input
is later used in a
shell command
.
This shell argument which depends on
library input
is later used in a
shell command
.
@maximejen
Copy link

maximejen commented Nov 7, 2023

Hello, I tried to install a fresh Renative install with this version : 1.0.0-feat-bonanza.4

rnv new
npx rnv run -p tvos

Template: @rnv/template-starter@1.0.0-feat-bonanza.4

I am forced to use this template as all of the others seem to use react-native 0.67 which is not compatible with XCode 15 (Yoga does not compile)

MacOS Version : 14.0 (23A344) (Sonoma)
Apple M1 Max
XCode 15
ruby 2.7.5
pod --version : 1.14.2

Command : npx rnv run -p tvos

Here is the log of the pod install :

pod install 

FAILED with ERROR: 

[!] Unable to find a specification for `React-utils` depended upon by `React-Core/DevSupport`
You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Command failed with exit code 1: pod install
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `./node_modules/react-native-tvos/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `./node_modules/react-native-tvos/third-party-podspecs/RCT-Folly.podspec`
Fetching podspec for `boost` from `./node_modules/react-native-tvos/third-party-podspecs/boost.podspec`
Fetching podspec for `fmt` from `./node_modules/react-native-tvos/third-party-podspecs/fmt.podspec`
Fetching podspec for `glog` from `./node_modules/react-native-tvos/third-party-podspecs/glog.podspec`
[!] Unable to find a specification for `React-utils` depended upon by `React-Core/DevSupport`

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Error: Command failed with exit code 1: pod install
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `./node_modules/react-native-tvos/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `./node_modules/react-native-tvos/third-party-podspecs/RCT-Folly.podspec`
Fetching podspec for `boost` from `./node_modules/react-native-tvos/third-party-podspecs/boost.podspec`
Fetching podspec for `fmt` from `./node_modules/react-native-tvos/third-party-podspecs/fmt.podspec`
Fetching podspec for `glog` from `./node_modules/react-native-tvos/third-party-podspecs/glog.podspec`
[!] Unable to find a specification for `React-utils` depended upon by `React-Core/DevSupport`

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.
    at makeError (./node_modules/execa/lib/error.js:60:11)
    at handlePromise (./node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

@mihaiblaga89
Copy link
Member Author

@maximejen this PR is still work in progress but I'll make sure to check the issue you mentioned. Any additional steps on how to reproduce it or you just installed RNV globally, created a new project and ran npx rnv run -p tvos in it?

@maximejen
Copy link

Yes, I figured it was still a WIP
No that's it.
At first I tried migrating a ReactNative Project into ReNative but this is even worse, so I tried to do a fresh install

basic steps are what I described

Any ideas or ints on how I could fix that myself ? Changing the Podfile is useless as rnv overides it.
Sadly the lastest version of ReNative is quite outdated (RN 0.67), this PR is my last resort since I made the "mistake" to update my Mac ahaha 😂

@mihaiblaga89
Copy link
Member Author

@maximejen no, this should work, I haven't encountered the issue that you're facing at all. I see your log mentions pod install, instead of

[ task ] [configure] runCocoaPods[1] forceUpdate:false
✔ Executing: bundle install
✔ Executing: bundle exec pod install
[ task ] [configure] updatePodsChecksum[1]

are you sure that's running RNV version 1? Can you post a full output maybe?

@maximejen
Copy link

maximejen commented Nov 7, 2023

Sorry for the delay, to install rnv I followed the documentation npm install -g rnv
rnv --version : 0.37.4

the 4 lines you gave me are in the output just before the like "pod install" in my case

I can give you a full output later. I will look for a newer version of rnv

looks like there is also a 1.0.0-feat-bonanza.4 for rnv, I am installing as I write this

 prevent the opening of a new terminal <= ios + tvos export
@mihaiblaga89
Copy link
Member Author

@maximejen then it makes sense. You're trying to use an older version of RNV with a newer template. Uninstall that version with npm uninstall -g rnv then install this version, npm install -g rnv@1.0.0-feat-bonanza.4. Then create a new project with this version. But I'd like to remind you again that this version is unstable 😀

@maximejen
Copy link

maximejen commented Nov 7, 2023

pod install is running now, with rnv 1.0.0 etc..

Yeah I get that the version is unstable, but still, it's the only version I can run on my mac, since the latest isn't compatible. It's no problem for me, as long as I can build and try to run on tizen / tvos / androidtv, I'm happy :)

Thanks for your fast answers 👍🏻

I'll do issues next time if I find anything that can be improved

@mihaiblaga89 mihaiblaga89 merged commit 7e759ba into main Nov 9, 2023
2 checks passed
@pavjacko pavjacko added this to the 1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] [tvOS] Can't run/build/export template starter on tvOS
4 participants