Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed from npm install to yarn add #730

Merged
merged 2 commits into from
Nov 13, 2021
Merged

changed from npm install to yarn add #730

merged 2 commits into from
Nov 13, 2021

Conversation

mihaiblaga89
Copy link
Member

Description

  • Describe the nature of the work / fix

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@codecov-commenter
Copy link

Codecov Report

Merging #730 (886e05d) into develop (3255eaf) will decrease coverage by 0.02%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #730      +/-   ##
===========================================
- Coverage    20.37%   20.34%   -0.03%     
===========================================
  Files           84       84              
  Lines         5645     5663      +18     
  Branches      1255     1260       +5     
===========================================
+ Hits          1150     1152       +2     
- Misses        3367     3378      +11     
- Partials      1128     1133       +5     
Flag Coverage Δ
rnvunittests 20.34% <7.69%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rnv/src/core/pluginManager/index.js 8.28% <0.00%> (ø)
packages/rnv/src/core/projectManager/index.js 5.66% <0.00%> (ø)
...kages/rnv/src/core/sdkManager/deviceUtils/apple.js 5.37% <0.00%> (-0.12%) ⬇️
...kages/rnv/src/core/sdkManager/deviceUtils/tizen.js 7.69% <0.00%> (ø)
...ages/rnv/src/engine-core/tasks/task.rnv.install.js 10.00% <0.00%> (ø)
packages/rnv/src/engine-core/tasks/task.rnv.new.js 2.12% <0.00%> (-0.02%) ⬇️
packages/rnv/src/core/systemManager/npmUtils.js 6.04% <12.50%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b978d...886e05d. Read the comment docs.

@mihaiblaga89 mihaiblaga89 merged commit c273134 into develop Nov 13, 2021
@pavjacko pavjacko deleted the fix/npm_to_yarn branch February 15, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants