This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Fixing window positioning bug in Mac OS X #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etWindowPosition before SDL_SetWindowSize since OS X windows resize from the bottom left corner (not the top left as in Windows).
| @@ -213,6 +213,15 @@ int clientHeight | |||
| IsBorderless ? SDL.SDL_bool.SDL_FALSE : SDL.SDL_bool.SDL_TRUE | |||
| ); | |||
|
|
|||
| // Because Mac resizes from the bottom, we have to get the position before changing | |||
There was a problem hiding this comment.
Multiline comments use /* */ blocks, per the not-at-all-hidden style guide:
Other than that, this all seems fine to me. To be honest I'm not sure how well this previously worked on certain Linux setups, either...
flibitijibibo
added a commit
that referenced
this pull request
May 18, 2014
…ter-osx Fixing window positioning bug in Mac OS X
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by moving the call to SDL_GetWindowPosition before SDL_SetWindowSize since OS X windows resize from the bottom left corner (not the top left as in Windows) which means that resizing the window will push the top edge up higher, but SDL_GetWindowPosition returns the top-left corner of the window, which has now shifted up. So we have to query the position prior to resizing if we want the proper previous location values.
This fixes both the default window position (which was wrong if you set anything other than the default resolution) as well as the position of the window when resizing it programmatically.