Add once to Utils #186
Add once to Utils #186
Conversation
| if (ran) { | ||
| return result; | ||
| } | ||
| ran = true; |
There was a problem hiding this comment.
shouldn't this appear after the function has been called?
|
Also needs documentation added to the |
|
updated with usage and documentation. |
|
no problem at all. updated usage case to have an example of click event. |
| // var myHanlder = function () { | ||
| // $.ajax({type: 'DELETE', url: 'someurl.com', data: {id: 1}}); | ||
| // }; | ||
| // this.on('click', utils.once(myHandler)); |
There was a problem hiding this comment.
would add this example to the docs too
|
Please could you squash your commits too (you can force push to your feature branch and this PR will be automatically updated) |
|
Squashed |
|
Great, thanks. Still need to move the |
|
Oddly enough it actually broke the tests when i changed it. I'm not exactly sure on the reasoning though. I can look into why it wouldn't work. |
| describe('once()', function () { | ||
| it('should only call a function once', function () { | ||
| var sum = 0; | ||
| var increment = utils.once(function () { sum++; }); |
|
Looks like it might have been because you referenced |
|
@necolas I think its fine as is no? |
|
@angus-c That seems correct. I can change it to either way. |
add once functionality to utils. Inspired by underscore/lodash.